diff mbox

[1/8] drm/i915/tracepoints: Tidy request event class

Message ID 20170221091350.14605-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Feb. 21, 2017, 9:13 a.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

At the moment only the global seqno is logged which is not set
until the request is ready for submission.

Add the per-contex seqno and the context hardware id which are
both interesting data points.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_trace.h | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Chris Wilson Feb. 21, 2017, 9:51 a.m. UTC | #1 
On Tue, Feb 21, 2017 at 09:13:43AM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> At the moment only the global seqno is logged which is not set
> until the request is ready for submission.
> 
> Add the per-contex seqno and the context hardware id which are
> both interesting data points.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Some minor conversation pieces, but on the whole, the series is
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Chris Wilson Feb. 21, 2017, 12:32 p.m. UTC | #2 
On Tue, Feb 21, 2017 at 09:51:51AM +0000, Chris Wilson wrote:
> On Tue, Feb 21, 2017 at 09:13:43AM +0000, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > At the moment only the global seqno is logged which is not set
> > until the request is ready for submission.
> > 
> > Add the per-contex seqno and the context hardware id which are
> > both interesting data points.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Some minor conversation pieces, but on the whole, the series is
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

And the updates lgtm, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
for all
-Chris
Tvrtko Ursulin Feb. 21, 2017, 1:22 p.m. UTC | #3 
On 21/02/2017 11:52, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/8] drm/i915/tracepoints: Tidy request event class (rev4)
> URL   : https://patchwork.freedesktop.org/series/19994/
> State : success
>
> == Summary ==
>
> Series 19994v4 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/19994/revisions/4/mbox/
>
> fi-bdw-5557u     total:253  pass:242  dwarn:0   dfail:0   fail:0   skip:11
> fi-bsw-n3050     total:253  pass:214  dwarn:0   dfail:0   fail:0   skip:39
> fi-bxt-j4205     total:253  pass:234  dwarn:0   dfail:0   fail:0   skip:19
> fi-bxt-t5700     total:83   pass:70   dwarn:0   dfail:0   fail:0   skip:12
> fi-byt-j1900     total:253  pass:226  dwarn:0   dfail:0   fail:0   skip:27
> fi-byt-n2820     total:253  pass:222  dwarn:0   dfail:0   fail:0   skip:31
> fi-hsw-4770      total:253  pass:237  dwarn:0   dfail:0   fail:0   skip:16
> fi-hsw-4770r     total:253  pass:237  dwarn:0   dfail:0   fail:0   skip:16
> fi-ilk-650       total:253  pass:203  dwarn:0   dfail:0   fail:0   skip:50
> fi-ivb-3520m     total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18
> fi-ivb-3770      total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18
> fi-kbl-7500u     total:253  pass:235  dwarn:0   dfail:0   fail:0   skip:18
> fi-skl-6260u     total:253  pass:243  dwarn:0   dfail:0   fail:0   skip:10
> fi-skl-6700hq    total:253  pass:236  dwarn:0   dfail:0   fail:0   skip:17
> fi-skl-6700k     total:253  pass:231  dwarn:4   dfail:0   fail:0   skip:18
> fi-skl-6770hq    total:253  pass:243  dwarn:0   dfail:0   fail:0   skip:10
> fi-snb-2520m     total:253  pass:225  dwarn:0   dfail:0   fail:0   skip:28
> fi-snb-2600      total:253  pass:224  dwarn:0   dfail:0   fail:0   skip:29
>
> 0a03ea9496b49746b4964d05cc1f483385d1df8a drm-tip: 2017y-02m-20d-17h-19m-56s UTC integration manifest
> fdf3bad drm/i915/tracepoints: Add hw_id to context tracepoints
> 6d071e3 drm/i915/tracepoints: Add backend level request in and out tracepoints
> ef730d9 drm/i915/tracepoints: Rename i915_gem_request_notify
> 8091bc4 drm/i915/tracepoints: Add request submit and execute tracepoints
> ef253f3 drm/i915/tracepoints: Remove unused i915_gem_request_complete
> 7430dbb drm/i915/tracepoints: Tidy i915_gem_request_wait_begin
> fd9296e drm/i915/tracepoints: Adjust i915_gem_ring_dispatch
> db2870b drm/i915/tracepoints: Tidy request event class

Pushed, thanks for the review.

Regards,

Tvrtko
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index 7a547cdfc381..4454872d487f 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -451,18 +451,23 @@  DECLARE_EVENT_CLASS(i915_gem_request,
 
 	    TP_STRUCT__entry(
 			     __field(u32, dev)
+			     __field(u32, ctx)
 			     __field(u32, ring)
 			     __field(u32, seqno)
+			     __field(u32, global)
 			     ),
 
 	    TP_fast_assign(
 			   __entry->dev = req->i915->drm.primary->index;
+			   __entry->ctx = req->ctx->hw_id;
 			   __entry->ring = req->engine->id;
-			   __entry->seqno = req->global_seqno;
+			   __entry->seqno = req->fence.seqno;
+			   __entry->global = req->global_seqno;
 			   ),
 
-	    TP_printk("dev=%u, ring=%u, seqno=%u",
-		      __entry->dev, __entry->ring, __entry->seqno)
+	    TP_printk("dev=%u, ring=%u, ctx=%u, seqno=%u, global=%u",
+		      __entry->dev, __entry->ring, __entry->ctx, __entry->seqno,
+		      __entry->global)
 );
 
 DEFINE_EVENT(i915_gem_request, i915_gem_request_add,