From patchwork Wed Mar 15 21:07:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9626675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B9D8E6048C for ; Wed, 15 Mar 2017 21:07:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACCCB26BE9 for ; Wed, 15 Mar 2017 21:07:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A1AF228346; Wed, 15 Mar 2017 21:07:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5B1632841A for ; Wed, 15 Mar 2017 21:07:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2C126E2F0; Wed, 15 Mar 2017 21:07:30 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 803236E2F0 for ; Wed, 15 Mar 2017 21:07:29 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id u132so6673189wmg.1 for ; Wed, 15 Mar 2017 14:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=kQxuUlITapQaFxs8mSEFL00zYkcb2Me7iTan/2Sg4OE=; b=c+WOfnbBaY94B1uYMvGSfoqVF9XsiX0BNBt0lrEjCTe6si3z4f9yGPt2IPe7pK95AK WpXrimXVn2TqKBnJUrqeCotnSK/NJlRlzFnO4u0cyG35KZCsCB7/qf75K8Gcbtd43kKr 8NxeanlkEqFj4kQU2kwmE/O/YCgLiGJh43t0icBDV33BOx6HNhmUxtazWTSRaa/5+F8s SqFcClnDeCXTNjWtdWR5QgePMeVrVg/pyOw/Oed0Q8VWN6KlBIHzv2D3jUWwbm+00kc9 0Tsw/enkWK8F+3labXo1V1Uh6f8tSY5aBVrjXzTVOX3yMn7N7R9vN3bfFejGvhTzFgRQ 2vnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=kQxuUlITapQaFxs8mSEFL00zYkcb2Me7iTan/2Sg4OE=; b=ic/hLLDdx/EjlYARf+LPs5w8X463hmAieeHG5GDKBLoD/9ayHg59FcYhvcErh6whXB S8Ig+NJmUbHW9ZX1jfXKIfHbahOzKHpIGHYCL3siT+vzWrbOrPMIpDXpFAKH7CFD0Q4W gaEeWhjstnj56VLYISowqqisQe39M68oxmd0IzwuYHxlS+yuBIMX9YJKC3lcja/T0LFp /OYTWkDL/nZKhmnChCxSQc6Aq/+heKFef0HMxtZV4ajQkXuIjWuV/29Kg8P4nRHfm2Gs ppFpUZC/evUd94Wc4ZanGo5J5IbVHW8JXJRe4TtfeJHk7GhP4LKEIlCZUzadvKO1QL5p pX6w== X-Gm-Message-State: AFeK/H16Kju2PZQm72rlQMjDAPzoe7ABnuXvhMWoGpT9n6PX4g3vu+Xi5Go80yBAEwWTAQ== X-Received: by 10.28.39.5 with SMTP id n5mr6174614wmn.16.1489612047930; Wed, 15 Mar 2017 14:07:27 -0700 (PDT) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id i133sm1807294wmg.26.2017.03.15.14.07.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 14:07:27 -0700 (PDT) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Wed, 15 Mar 2017 21:07:22 +0000 Message-Id: <20170315210726.12095-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.11.0 Subject: [Intel-gfx] [CI 1/5] drm/i915/breadcrumbs: Use booleans for intel_breadcrumbs_busy() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Since commit 9b6586ae9f6b ("drm/i915: Keep a global seqno per-engine") converted intel_breadcrumbs_busy() to reporting a single boolean, we need only compute a boolean internally (and not needlessly compute the flag). Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c index 2a1ed6d7ad4d..3f222dee4c25 100644 --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c @@ -828,12 +828,12 @@ bool intel_breadcrumbs_busy(struct intel_engine_cs *engine) if (b->irq_wait) { wake_up_process(b->irq_wait->tsk); - busy |= intel_engine_flag(engine); + busy = true; } if (rcu_access_pointer(b->first_signal)) { wake_up_process(b->signaler); - busy |= intel_engine_flag(engine); + busy = true; } spin_unlock_irq(&b->rb_lock);