From patchwork Wed Mar 22 08:36:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9638287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1CCB3602CB for ; Wed, 22 Mar 2017 08:38:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12053279E0 for ; Wed, 22 Mar 2017 08:38:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06EDD27B2F; Wed, 22 Mar 2017 08:38:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C686C279E0 for ; Wed, 22 Mar 2017 08:38:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F27D96E856; Wed, 22 Mar 2017 08:36:46 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id A978E6E833 for ; Wed, 22 Mar 2017 08:36:39 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id z133so7633078wmb.2 for ; Wed, 22 Mar 2017 01:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wxszLsxP39wvmYrtX4vvQ981pzh4WQH7FWTxpon+sLA=; b=LcdTJqbI1GevnMJLIyiVPy3GFOfQSpoPhDtg0falt+ETyPFAG+hE4Z7u04V6VJOYjW fjG/iFFEQp0Vx7die1rSEr3op8J0eKkFZ+Vp8FbnavH/mCYMYetAIAPHHhGjZyidx0yZ PVJuPpqQ4OV/PSLQVojPqlPQMVJqRfR1Wtq0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wxszLsxP39wvmYrtX4vvQ981pzh4WQH7FWTxpon+sLA=; b=Cl+FBTdyieyzkVI2miSnwHg4W6wuhfuWxhUwP5UoTtV51fHuzWgmNcFnVXrkIVV7p2 obtp4PmP7PEojxFV0uk2oCLjjlfzMoWldo7w+LjIQd/xm5G2g7W5S2VFNWyklhC1e5qI u786cCGe0SZUT/o3hpHRJ8ZwlXk909K10/hLRKlRtMqOwkxd5tKFvNM9GbTk7XgXkDvr s2kRGDPgGoLFX1LBnLym5Pu4RoIDPBqbacc0pQHTh5O/wmCSohhsrqddINqXhc5Oxuir hYwCdL2BsbNtZ0klg+I19hyG6mTgtWZaBOgL0NB+ZrXFpkHAvPMetQveu/gwFda01lu0 ldiQ== X-Gm-Message-State: AFeK/H08BtGYbOrdvhReuxPME69xHrjr+NduZQ1gMO2ovwafCU7sIS5BzEC4jnpvVbXpkw== X-Received: by 10.28.69.202 with SMTP id l71mr6754513wmi.68.1490171798252; Wed, 22 Mar 2017 01:36:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56c9:0:decc:6e78:7e96:b452]) by smtp.gmail.com with ESMTPSA id g45sm927438wrd.11.2017.03.22.01.36.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 01:36:37 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Wed, 22 Mar 2017 09:36:14 +0100 Message-Id: <20170322083617.13361-14-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170322083617.13361-1-daniel.vetter@ffwll.ch> References: <20170322083617.13361-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , DRI Development , Daniel Vetter Subject: [Intel-gfx] [PATCH 13/16] drm/vblank: Add FIXME comments about moving the vblank ts hooks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This is going to be a bit too much, but good to have at least a small note about where this should all head towards. Signed-off-by: Daniel Vetter --- include/drm/drm_drv.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 9fe6301edd6a..0a367cf5d8d5 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -274,6 +274,11 @@ struct drm_driver { * constant but unknown small number of scanlines wrt. real scanout * position. * + * FIXME: + * + * Since this is a helper to implement @get_vblank_timestamp, we should + * move it to &struct drm_crtc_helper_funcs, like all the other + * helper-internal hooks. */ int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe, unsigned int flags, int *vpos, int *hpos, @@ -317,6 +322,11 @@ struct drm_driver { * * True on success, false on failure, which means the core should * fallback to a simple timestamp taken in drm_crtc_handle_vblank(). + * + * FIXME: + * + * We should move this hook to &struct drm_crtc_funcs like all the other + * vblank hooks. */ bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe, int *max_error,