From patchwork Tue Apr 4 09:53:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9661081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A117760352 for ; Tue, 4 Apr 2017 09:53:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CADA284CB for ; Tue, 4 Apr 2017 09:53:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7EFD9284D5; Tue, 4 Apr 2017 09:53:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 27846284CB for ; Tue, 4 Apr 2017 09:53:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 894FF6E583; Tue, 4 Apr 2017 09:53:25 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F0946E575 for ; Tue, 4 Apr 2017 09:53:23 +0000 (UTC) Received: by mail-wr0-x241.google.com with SMTP id u18so40666260wrc.0 for ; Tue, 04 Apr 2017 02:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wxszLsxP39wvmYrtX4vvQ981pzh4WQH7FWTxpon+sLA=; b=Z4xqax7nlYY7woY/LWpOORHQOiiB72fb4VFFsOjKqTuIvKUTGPoTr01DpcLMAx+R8X UEs1F0IVE8cGlcboKYRyC6+ACxAJX2BjrBj+gZbfmexnlTGY7f7U6BKwc1GFX0IjWh3v Vn8t+UPENIRixkgf+EEUbMjx+hgSC9Kn3nM+Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wxszLsxP39wvmYrtX4vvQ981pzh4WQH7FWTxpon+sLA=; b=Fn+3eYX2ITGSCna1j6vyCBnkGqqPKlx8JzpyYyDu6ytQEY+QAJzO6KNEdk5MM2Sebu R0F6L5xSsiUZgZs1QdkG4Uo6yrf3U2VO8OxfZP80wv+JN4UbLNRtNPNd9MwTg4XvjivO OAWkUsbdmU/J/DF93F+SQTx+OOxiX9dZrP7XcTC9XG0nc8wgkErtyRIwyau7vkvlPGut qjCvcoiJG+ylRMYDg88A7eCMeTlOw003r36Lb/RHsFJHfN9HirHP8PSFfS0bLQBdk+Ga ic4Tpr8XDN/1A1NVD8xNae2QucCWbv4hriLqMjgQcx3Y1EMo8G+kytMMGwTrvSfoGS1i Cp5A== X-Gm-Message-State: AFeK/H0oaIRc4E8x/wfl2uS+9fTh5B62Wiw7tAVOMim8+177fYNbj4xx X315KnQ7QWxThA== X-Received: by 10.28.47.205 with SMTP id v196mr14270055wmv.20.1491299602079; Tue, 04 Apr 2017 02:53:22 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:563a:0:c2b5:dd51:f7b6:65bb]) by smtp.gmail.com with ESMTPSA id 134sm17689986wmj.6.2017.04.04.02.53.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 02:53:21 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Tue, 4 Apr 2017 11:53:00 +0200 Message-Id: <20170404095304.17599-7-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170404095304.17599-1-daniel.vetter@ffwll.ch> References: <20170404095304.17599-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Subject: [Intel-gfx] [PATCH 07/11] drm/vblank: Add FIXME comments about moving the vblank ts hooks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This is going to be a bit too much, but good to have at least a small note about where this should all head towards. Signed-off-by: Daniel Vetter Reviewed-by: Neil Armstrong --- include/drm/drm_drv.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 9fe6301edd6a..0a367cf5d8d5 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -274,6 +274,11 @@ struct drm_driver { * constant but unknown small number of scanlines wrt. real scanout * position. * + * FIXME: + * + * Since this is a helper to implement @get_vblank_timestamp, we should + * move it to &struct drm_crtc_helper_funcs, like all the other + * helper-internal hooks. */ int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe, unsigned int flags, int *vpos, int *hpos, @@ -317,6 +322,11 @@ struct drm_driver { * * True on success, false on failure, which means the core should * fallback to a simple timestamp taken in drm_crtc_handle_vblank(). + * + * FIXME: + * + * We should move this hook to &struct drm_crtc_funcs like all the other + * vblank hooks. */ bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe, int *max_error,