| Message ID | 20170411111336.28104-1-ander.conselvan.de.oliveira@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 206f852..1208d90 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -372,6 +372,14 @@ static void run_test(data_t *data, void (*testfunc)(data_t *), int cursor_w, int kmstest_pipe_name(data->pipe), igt_output_name(output)); + /* + * Force test to use full range RGB. Limited range causes CRC + * mismatches in SKL and GLK. + */ + kmstest_set_connector_broadcast_rgb(data->drm_fd, + data->output->config.connector, + BROADCAST_RGB_FULL); + testfunc(data); igt_info("\n%s on pipe %s, connector %s: PASSED\n\n",
In at least SKL and GLK (possibly other devices too), using a cursor plane to scan out an fb might result in a different pipe crc than when using a regular plane at the same position with the same fb while using the CSC logic to limit the color range. The differences could be caused by the cursor plane being limited to 8 bpc while the regular planes support higher bit depths, leading to slightly different values to be used internally. This is evidenced by the failures happening with specific color values, 0.5 for example, but that's mostly speculation. v2: Add more details to the commit message. Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> --- tests/kms_cursor_crc.c | 8 ++++++++ 1 file changed, 8 insertions(+)