From patchwork Tue Apr 18 12:11:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9685445 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97297602C2 for ; Tue, 18 Apr 2017 12:11:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AAA1283F1 for ; Tue, 18 Apr 2017 12:11:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F93B28449; Tue, 18 Apr 2017 12:11:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 50F13283F1 for ; Tue, 18 Apr 2017 12:11:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 158AD89AB6; Tue, 18 Apr 2017 12:11:30 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93B3789AB6 for ; Tue, 18 Apr 2017 12:11:28 +0000 (UTC) Received: by mail-wr0-x241.google.com with SMTP id o21so24500498wrb.3 for ; Tue, 18 Apr 2017 05:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=yNU/jJogfovrtYOYM4qv8VV/00cDlDQdouRyp9EWduw=; b=kW6jVFXcWlS02Xz3lyEnS24ut294Wb7EzPYTyfa81vNOvT9Y/QL4KQPKDYp6M7DCBT 6xId0Tt0Uqi/48RLM4sTZhWDCLY5syJY9YMPWHfbdMkY2F+bn1VebphNCXV8cJPs1pwt V0K7JZ9wdrGlc+h+qKB/l2ETOfvlVSpA8MOVw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yNU/jJogfovrtYOYM4qv8VV/00cDlDQdouRyp9EWduw=; b=p3zbXrEfDuG++l6BzVcXXQ3Ag+QUnU+VcIja8PdpyU8Q8pr1h8Hy0TqIJ85IMSxsYe hvLOiCEQtD7YgX9nmYdFRH64lyL/glp2US5l1W6mz/2eNu7v1uFH51+Up4M7tYqHs6Iq JPa5+vnjMjgl0OKtk4umtjPM0DeLJ1aIg238uJN0EAnD1E/9iBIXv8R5Z9p2PhYw2vrq kN7A0P0SlPauNEoW/Ok/MZXmmwJgngsOBFyjw0rEauXCBwjz450xIH/tbkShfE20TbeV T21RU0zQ1ZNB/wzet5+kfztdSPQmI0p5MqPUi579H//LWWT8qGg9b/3aXE7FxHLfpBlU ZzEw== X-Gm-Message-State: AN3rC/7smKiDC6KvoJlrK/jIfUDHsMJD++xl7efsuDxazm8fJOQbZYlV Yob4xjwqpaqdzw== X-Received: by 10.223.134.203 with SMTP id 11mr24722680wry.149.1492517487233; Tue, 18 Apr 2017 05:11:27 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id 135sm2450644wmi.1.2017.04.18.05.11.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Apr 2017 05:11:26 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Tue, 18 Apr 2017 14:11:20 +0200 Message-Id: <20170418121120.31862-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart , Daniel Vetter Subject: [Intel-gfx] [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP All the error codes we (ab)use are strictly not the right ones (since they're all for the vfs, and the only thing we're allowed to do from an ioctl is EINVAL). But ENOENT is the common error code for failed to look up an object throughout drm, so let's use it in the cma helpers, too. Cc: Laurent Pinchart Signed-off-by: Daniel Vetter Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index d2b77b02830d..53f9bdf470d7 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -189,7 +189,7 @@ struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device *dev, obj = drm_gem_object_lookup(file_priv, mode_cmd->handles[i]); if (!obj) { dev_err(dev->dev, "Failed to lookup GEM object\n"); - ret = -ENXIO; + ret = -ENOENT; goto err_gem_object_put; }