| Message ID | 20170511195922.15844-12-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chris Wilson <chris@chris-wilson.co.uk> writes: > Since we coordinate with the execlists tasklet using a locked schedule > operation that ensures that after we set the engine->irq_posted we > always have an invocation of the tasklet, we do not need to use a locked > operation to set the engine->irq_posted itself. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> This has r-b from Tvrtko. -Mika > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index a58152dd7021..7b7f55a28eec 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1324,7 +1324,7 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift) > > if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) { > if (port_count(&engine->execlist_port[0])) { > - set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); > + __set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); > tasklet = true; > } > } > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 11/05/2017 20:59, Chris Wilson wrote: > Since we coordinate with the execlists tasklet using a locked schedule > operation that ensures that after we set the engine->irq_posted we > always have an invocation of the tasklet, we do not need to use a locked > operation to set the engine->irq_posted itself. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index a58152dd7021..7b7f55a28eec 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1324,7 +1324,7 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift) > > if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) { > if (port_count(&engine->execlist_port[0])) { > - set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); > + __set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); > tasklet = true; > } > } > As Mika said - once more: Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> :) Regards, Tvrtko
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index a58152dd7021..7b7f55a28eec 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1324,7 +1324,7 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift) if (iir & (GT_CONTEXT_SWITCH_INTERRUPT << test_shift)) { if (port_count(&engine->execlist_port[0])) { - set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); + __set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted); tasklet = true; } }
Since we coordinate with the execlists tasklet using a locked schedule operation that ensures that after we set the engine->irq_posted we always have an invocation of the tasklet, we do not need to use a locked operation to set the engine->irq_posted itself. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)