From patchwork Wed May 24 14:51:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9746151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E7F9160209 for ; Wed, 24 May 2017 14:53:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE6C12852A for ; Wed, 24 May 2017 14:53:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D38052877B; Wed, 24 May 2017 14:53:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 795362852A for ; Wed, 24 May 2017 14:53:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D44146E79A; Wed, 24 May 2017 14:52:43 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90EF96E78B for ; Wed, 24 May 2017 14:52:39 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id k15so46613144wmh.3 for ; Wed, 24 May 2017 07:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=466uw9kkxbJZLLFNRX5Q9QtEMdYZZSNkUunLy/zCwQg=; b=DpeABA62WsIZLTNAqqlawL3vqvkjaZ72rRUbQSPtzlSXvpLlxFyf1OMOUgG26eW/+z dPQY6LTMUFaWib0507nGT8++SvNnfFScXP16BV82RaAvijKs6pqUuxRTstwjXFxJsdTl 1oyUX69sgTy9UJKsQbV6skSRpEBakBZLi+PYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=466uw9kkxbJZLLFNRX5Q9QtEMdYZZSNkUunLy/zCwQg=; b=P+LpO0/TWiPOcrHRvC2R4p6oNMdDfdJPR4A1gNYuttjvx23u8LNNMgNl5gQsM2z6k6 5zxDIxdvb8JAKRz+lLutPwymTAqq3kZZdTiPlv1iBC1fiJIx/HlqHVr+kG8vpHEo2YMO TmvqtboFgTccZyJAdhJ8iXmHXm9RMAoIGMyLZQpT+NyalGLKGmreIe3FSvHygjkCW/Wd oYa8Oe3XS5AxaJ9R+wS1BVl4avCDnSpkY9a5mPDQaRSiaFTbkQ66MpzbP9euQhLRBbNU YhF/3oHoyXORWTaTZd/cXdK4gXccj7vQw64gLzgK86pCvVlsoa90iWrv3M57FOBijA3q TPXg== X-Gm-Message-State: AODbwcBpOA4CY8SitMtotPKMyJP3ZgR1vc5fJLFuLTRoleKyBrv/FRl0 0JkXO+J/mtI915eP X-Received: by 10.80.163.213 with SMTP id t21mr25456047edb.158.1495637558202; Wed, 24 May 2017 07:52:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id m9sm1778858edm.62.2017.05.24.07.52.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 07:52:37 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Wed, 24 May 2017 16:51:50 +0200 Message-Id: <20170524145212.27837-16-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170524145212.27837-1-daniel.vetter@ffwll.ch> References: <20170524145212.27837-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Alexey Brodkin , Daniel Vetter Subject: [Intel-gfx] [PATCH 15/37] drm/arcgpu: Drop drm_vblank_cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP CRTC don't seem to get shut down in a controlled fashion, but no one bothers to stop interrupts either so this races no matter what. Might as well remove it. A call to drm_atomic_helper_shutdown would be pretty sweet somewhere (and maybe getting rid of the load/unload callbacks while at it). Cc: Alexey Brodkin Signed-off-by: Daniel Vetter Reviewed-by: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index 1926b200e4cb..3e43a5d4fb09 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -155,7 +155,6 @@ static int arcpgu_unload(struct drm_device *drm) arcpgu->fbdev = NULL; } drm_kms_helper_poll_fini(drm); - drm_vblank_cleanup(drm); drm_mode_config_cleanup(drm); return 0;