From patchwork Wed May 24 14:51:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9746237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C60F60209 for ; Wed, 24 May 2017 14:56:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 128EB2896F for ; Wed, 24 May 2017 14:56:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0775E2899A; Wed, 24 May 2017 14:56:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA8F52896F for ; Wed, 24 May 2017 14:56:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 580476E774; Wed, 24 May 2017 14:53:33 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1A0A6E7A3 for ; Wed, 24 May 2017 14:52:44 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id b84so31980314wmh.0 for ; Wed, 24 May 2017 07:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OjADPwYYO6xNEF1DkF8wbGgoI+wcS3rJB7HwjXDkPtQ=; b=MLv6Onvr8Rx1BQyXMcGuWh1cyUFyzRMAykx9nLJ9Uh9R6phYLBE6WCftOp2x+kjSuo d/DhrUeKtXs/ejVjlcPN7ENnzKl5zHWAIQLM5wD2Xmk6cEx4ScpDeejShuS/yqI/IKMW B3wID9iG2KMfummxtSLL9qAW3Jt0lLhDVknqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OjADPwYYO6xNEF1DkF8wbGgoI+wcS3rJB7HwjXDkPtQ=; b=qfdqV23x48IPv58Z5+t/EwciSZF+o8W1inwU5fPhtmnIxiczqKwFzXnBj+1VqRjtSb uqGar//lnmgDU7kxKTsHvAGPzag4TgaHqtL1fl5IzMLOBiN/oyzS4lL/5RL2bcCxxhEg oiKwvKmhSyEXIJqaPavC+BzlMfY2RNIvNcwyG1+CvWuC0ZvTyGJSeD3gNbGysKmbDoO1 sqNWpMmRphbf4R/eT98eV4H7400xcGHox1FPAbSb2ZQWzgjRs1vj6F0OYjTFZTqbA65L w7+AJxCZxC1M65rqxUKXXZZv9kyaaRM0NU0DfwH8lkaU8ok4RnpdZU3UKWViZGRYyFhX E92A== X-Gm-Message-State: AODbwcAopCYveIuJB/lm5G9jBiOESfjOjWqGNe0HdmfkaGENvA/CJl6v 4VIt5fd5y3AiKZZw X-Received: by 10.80.172.228 with SMTP id x91mr21884074edc.66.1495637563474; Wed, 24 May 2017 07:52:43 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id m9sm1778858edm.62.2017.05.24.07.52.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 07:52:42 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Wed, 24 May 2017 16:51:54 +0200 Message-Id: <20170524145212.27837-20-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170524145212.27837-1-daniel.vetter@ffwll.ch> References: <20170524145212.27837-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Stefan Agner Subject: [Intel-gfx] [PATCH 19/37] drm/fsl: Drop drm_vblank_cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Again cleanup before irq disabling doesn't really stop the races, so just drop it. Proper fix would be to put drm_atomic_helper_shutdown before everything gets cleaned up. Cc: Stefan Agner Signed-off-by: Daniel Vetter Acked-by: Stefan Agner --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index 6e00f4b267f1..b34d09b59eee 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -109,7 +109,6 @@ static int fsl_dcu_load(struct drm_device *dev, unsigned long flags) drm_fbdev_cma_fini(fsl_dev->fbdev); drm_mode_config_cleanup(dev); - drm_vblank_cleanup(dev); drm_irq_uninstall(dev); dev->dev_private = NULL; @@ -127,7 +126,6 @@ static void fsl_dcu_unload(struct drm_device *dev) drm_fbdev_cma_fini(fsl_dev->fbdev); drm_mode_config_cleanup(dev); - drm_vblank_cleanup(dev); drm_irq_uninstall(dev); dev->dev_private = NULL;