From patchwork Tue Jul 4 13:33:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Kocialkowki X-Patchwork-Id: 9825029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1EC30602F0 for ; Tue, 4 Jul 2017 13:33:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0545E2094F for ; Tue, 4 Jul 2017 13:33:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED93227FB1; Tue, 4 Jul 2017 13:33:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5CAEC2094F for ; Tue, 4 Jul 2017 13:33:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A93C76E138; Tue, 4 Jul 2017 13:33:24 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B465B6E138 for ; Tue, 4 Jul 2017 13:33:23 +0000 (UTC) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2017 06:33:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,307,1496127600"; d="scan'208";a="104336340" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 04 Jul 2017 06:33:23 -0700 Received: from workstation.fi.intel.com (workstation.fi.intel.com [10.237.68.144]) by linux.intel.com (Postfix) with ESMTP id 3D27F580204; Tue, 4 Jul 2017 06:33:21 -0700 (PDT) From: Paul Kocialkowski To: intel-gfx@lists.freedesktop.org Date: Tue, 4 Jul 2017 16:33:17 +0300 Message-Id: <20170704133319.5130-1-paul.kocialkowski@linux.intel.com> X-Mailer: git-send-email 2.13.2 Cc: Lyude Subject: [Intel-gfx] [PATCH i-g-t v4 1/3] tests/chamelium: Update connector state without reprobe when possible X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This renames the reprobe_connector function to update_connector and ensures that full reprobe of the connector is only done when really necessary (e.g. when changing the EDID). A full reprobe takes time and is not required for updating the connector state. Thus, this allows executing tests faster. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index b412c6a7..346018a5 100644 --- a/tests/chamelium.c +++ b/tests/chamelium.c @@ -103,13 +103,14 @@ require_connector_present(data_t *data, unsigned int type) } static drmModeConnection -reprobe_connector(data_t *data, struct chamelium_port *port) +update_connector(data_t *data, struct chamelium_port *port, bool reprobe) { drmModeConnector *connector; drmModeConnection status; - igt_debug("Reprobing %s...\n", chamelium_port_get_name(port)); - connector = chamelium_port_get_connector(data->chamelium, port, true); + igt_debug("Updating %s...\n", chamelium_port_get_name(port)); + connector = chamelium_port_get_connector(data->chamelium, port, + reprobe); igt_assert(connector); status = connector->connection; @@ -119,7 +120,7 @@ reprobe_connector(data_t *data, struct chamelium_port *port) static void wait_for_connector(data_t *data, struct chamelium_port *port, - drmModeConnection status) + drmModeConnection status, bool reprobe) { bool finished = false; @@ -132,7 +133,7 @@ wait_for_connector(data_t *data, struct chamelium_port *port, * that hpd events work in the event that hpd doesn't work on the system */ igt_until_timeout(HOTPLUG_TIMEOUT) { - if (reprobe_connector(data, port) == status) { + if (update_connector(data, port, reprobe) == status) { finished = true; return; } @@ -151,11 +152,12 @@ reset_state(data_t *data, struct chamelium_port *port) chamelium_reset(data->chamelium); if (port) { - wait_for_connector(data, port, DRM_MODE_DISCONNECTED); + wait_for_connector(data, port, DRM_MODE_DISCONNECTED, false); } else { for (p = 0; p < data->port_count; p++) { port = data->ports[p]; - wait_for_connector(data, port, DRM_MODE_DISCONNECTED); + wait_for_connector(data, port, DRM_MODE_DISCONNECTED, + false); } } } @@ -175,7 +177,7 @@ test_basic_hotplug(data_t *data, struct chamelium_port *port, int toggle_count) /* Check if we get a sysfs hotplug event */ chamelium_plug(data->chamelium, port); igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)); - igt_assert_eq(reprobe_connector(data, port), + igt_assert_eq(update_connector(data, port, false), DRM_MODE_CONNECTED); igt_flush_hotplugs(mon); @@ -183,7 +185,7 @@ test_basic_hotplug(data_t *data, struct chamelium_port *port, int toggle_count) /* Now check if we get a hotplug from disconnection */ chamelium_unplug(data->chamelium, port); igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)); - igt_assert_eq(reprobe_connector(data, port), + igt_assert_eq(update_connector(data, port, false), DRM_MODE_DISCONNECTED); } @@ -204,7 +206,7 @@ test_edid_read(data_t *data, struct chamelium_port *port, chamelium_port_set_edid(data->chamelium, port, edid_id); chamelium_plug(data->chamelium, port); - wait_for_connector(data, port, DRM_MODE_CONNECTED); + wait_for_connector(data, port, DRM_MODE_CONNECTED, true); igt_assert(kmstest_get_property(data->drm_fd, connector->connector_id, DRM_MODE_OBJECT_CONNECTOR, "EDID", NULL, @@ -247,13 +249,13 @@ try_suspend_resume_hpd(data_t *data, struct chamelium_port *port, igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)); if (port) { - igt_assert_eq(reprobe_connector(data, port), connected ? + igt_assert_eq(update_connector(data, port, false), connected ? DRM_MODE_DISCONNECTED : DRM_MODE_CONNECTED); } else { for (p = 0; p < data->port_count; p++) { port = data->ports[p]; - igt_assert_eq(reprobe_connector(data, port), connected ? - DRM_MODE_DISCONNECTED : + igt_assert_eq(update_connector(data, port, false), + connected ? DRM_MODE_DISCONNECTED : DRM_MODE_CONNECTED); } @@ -317,7 +319,7 @@ test_suspend_resume_edid_change(data_t *data, struct chamelium_port *port, /* First plug in the port */ chamelium_port_set_edid(data->chamelium, port, edid_id); chamelium_plug(data->chamelium, port); - wait_for_connector(data, port, DRM_MODE_CONNECTED); + wait_for_connector(data, port, DRM_MODE_CONNECTED, true); igt_flush_hotplugs(mon); @@ -352,7 +354,7 @@ prepare_output(data_t *data, chamelium_port_set_edid(data->chamelium, port, data->edid_id); chamelium_plug(data->chamelium, port); - wait_for_connector(data, port, DRM_MODE_CONNECTED); + wait_for_connector(data, port, DRM_MODE_CONNECTED, true); igt_display_init(display, data->drm_fd); output = igt_output_from_connector(display, connector); @@ -590,7 +592,7 @@ test_hpd_without_ddc(data_t *data, struct chamelium_port *port) chamelium_plug(data->chamelium, port); igt_assert(igt_hotplug_detected(mon, HOTPLUG_TIMEOUT)); - igt_assert_eq(reprobe_connector(data, port), DRM_MODE_CONNECTED); + igt_assert_eq(update_connector(data, port, false), DRM_MODE_CONNECTED); igt_cleanup_hotplug(mon); }