From patchwork Thu Jul 6 13:00:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9828243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 60E8C60361 for ; Thu, 6 Jul 2017 13:00:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2844C28674 for ; Thu, 6 Jul 2017 13:00:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25A242862C; Thu, 6 Jul 2017 13:00:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 06EB928675 for ; Thu, 6 Jul 2017 13:00:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4174E6E5E7; Thu, 6 Jul 2017 13:00:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62F396E5E7 for ; Thu, 6 Jul 2017 13:00:30 +0000 (UTC) Received: by mail-lf0-x243.google.com with SMTP id f28so225075lfi.3 for ; Thu, 06 Jul 2017 06:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=C98izmHBJkhimYePe5zdYn4LVOTGoCxHG2bcI0+OGDw=; b=QUlu59VS8RA9GfLaOaX6FaMCemVk+oge9Zzl5FQX8lnMGgLxr7K6JkK/xC2/puNdKU MJLtx/iVEOjtFpx4B+1A6qYAMDzXg+LgYooPoFj4Slk6luumKMk8JQUXteKUWNt3sIvU TutDmjB3gisAn5jxwvwzDcu254ld2m21L1aHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=C98izmHBJkhimYePe5zdYn4LVOTGoCxHG2bcI0+OGDw=; b=HdjGAgTDxVPl7vzoNF6oCMwbnOUVeGbTGoJJpiHKRBrLHl8WVJWcKn0KmihkFxmzLZ 4qRKq7cOUZHgwnzi5ecLuh3c/9JXSlR370dlRmd/loJyhEapKluU5nErEa7mTWSvowPS m69bL07RJ1K5a1K40eXg5ZCBdGmGluiZbIsH/AafTymA4dLIjAoVPYmm8Shv4mvwjnKm PbBuG/xXzIzjmLxKHymIDK1w+6r0DgwtCi3R+L4HBTVMaIZGL6lT/X6I7OFqLmrwbKCh uWqkpSz3bAl51APa7FM4zGFPSBnBhdsGacWeSI4xMmrxL/lRl9tvMAZErSuIVyRUNpn1 hztA== X-Gm-Message-State: AIVw112PoXi7iB4oRz/Mn/cDQCgv4R02Y0fcQd4xejejecmIjay03H3Q ygREgB+4fwA7QVlK X-Received: by 10.80.209.195 with SMTP id i3mr18218430edg.70.1499346028832; Thu, 06 Jul 2017 06:00:28 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id a20sm132884edd.60.2017.07.06.06.00.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 06:00:28 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Thu, 6 Jul 2017 15:00:19 +0200 Message-Id: <20170706130023.28417-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.13.2 Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter , Mika Kuoppala Subject: [Intel-gfx] [PATCH 1/5] drm/i915/fbdev: Always forward hotplug events X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP With deferred fbdev setup we always need to forward hotplug events, even if fbdev isn't fully set up yet. Otherwise the deferred setup will neer happen. Originally this check was added in commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag: drm-intel-next-fixes-2016-08-05) Author: Chris Wilson Date: Wed Jul 13 18:34:45 2016 +0100 drm/i915/fbdev: Check for the framebuffer before use But the specific case of the hotplug function blowing up was fixed in commit 50c3dc970a09b3b60422a58934cc27a413288bab Author: Daniel Vetter Date: Fri Jun 27 17:19:22 2014 +0200 drm/fb-helper: Fix hpd vs. initial config races Cc: Maarten Lankhorst Cc: Mika Kuoppala Cc: Chris Wilson Signed-off-by: Daniel Vetter Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index f11ee039ff45..5536591d3da0 100644 --- a/drivers/gpu/drm/i915/intel_fbdev.c +++ b/drivers/gpu/drm/i915/intel_fbdev.c @@ -821,7 +821,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev) { struct intel_fbdev *ifbdev = to_i915(dev)->fbdev; - if (ifbdev && ifbdev->vma) + if (ifbdev) drm_fb_helper_hotplug_event(&ifbdev->helper); }