| Message ID | 20170717142726.18761-1-paul.kocialkowski@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 17 Jul 2017, Paul Kocialkowski <paul.kocialkowski@linux.intel.com> wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. Perhaps more consistent would be using a prefix like this: DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", connector->base.base.id, connector->base.name); BR, Jani. > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > index b79c1c0e404c..75a411c94ce5 100644 > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > if (!intel_dp_link_training_channel_equalization(intel_dp)) > goto failure_handling; > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > - intel_dp->link_rate, intel_dp->lane_count); > + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s", > + intel_dp->link_rate, intel_dp->lane_count, > + intel_connector->base.name); > return; > > failure_handling: > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > - intel_dp->link_rate, intel_dp->lane_count); > + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d for connector %s", > + intel_dp->link_rate, intel_dp->lane_count, > + intel_connector->base.name); > if (!intel_dp_get_link_train_fallback_values(intel_dp, > intel_dp->link_rate, > intel_dp->lane_count))
Hey, On Tue, 2017-07-18 at 10:38 +0300, Jani Nikula wrote: > On Mon, 17 Jul 2017, Paul Kocialkowski <paul.kocialkowski@linux.intel. > com> wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connector is > > failing when multiple DP connectors are used. > > Perhaps more consistent would be using a prefix like this: > > DRM_DEBUG_KMS("[CONNECTOR:%d:%s] bla bla blaa\n", > connector->base.base.id, connector->base.name); You are definitely right, this is what is used all over the place in the driver, so I should stick to it. Thanks for the suggestion, I will send out v2 in that direction shortly. Cheers, Paul > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com> > > --- > > drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c > > b/drivers/gpu/drm/i915/intel_dp_link_training.c > > index b79c1c0e404c..75a411c94ce5 100644 > > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > > @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp > > *intel_dp) > > if (!intel_dp_link_training_channel_equalization(intel_dp)) > > goto failure_handling; > > > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > return; > > > > failure_handling: > > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d", > > - intel_dp->link_rate, intel_dp->lane_count); > > + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane > > count = %d for connector %s", > > + intel_dp->link_rate, intel_dp->lane_count, > > + intel_connector->base.name); > > if (!intel_dp_get_link_train_fallback_values(intel_dp, > > intel_dp- > > >link_rate, > > intel_dp- > > >lane_count)) > >
diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index b79c1c0e404c..75a411c94ce5 100644 --- a/drivers/gpu/drm/i915/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c @@ -321,13 +321,15 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) if (!intel_dp_link_training_channel_equalization(intel_dp)) goto failure_handling; - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", - intel_dp->link_rate, intel_dp->lane_count); + DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d for connector %s", + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name); return; failure_handling: - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", - intel_dp->link_rate, intel_dp->lane_count); + DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d for connector %s", + intel_dp->link_rate, intel_dp->lane_count, + intel_connector->base.name); if (!intel_dp_get_link_train_fallback_values(intel_dp, intel_dp->link_rate, intel_dp->lane_count))
This adds the connector name when printing a debug message about the DP link training result. It is useful to figure out what connector is failing when multiple DP connectors are used. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp_link_training.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)