From patchwork Mon Jul 17 19:58:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 9846025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8EA660212 for ; Mon, 17 Jul 2017 19:59:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC1AA27F7F for ; Mon, 17 Jul 2017 19:59:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF52A28462; Mon, 17 Jul 2017 19:59:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B50527F7F for ; Mon, 17 Jul 2017 19:59:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87C7E6E27F; Mon, 17 Jul 2017 19:59:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id E85C56E27F for ; Mon, 17 Jul 2017 19:59:29 +0000 (UTC) Received: by mail-pg0-f48.google.com with SMTP id u5so22624349pgq.3 for ; Mon, 17 Jul 2017 12:59:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vq2W7ivYMkOpmTax7LkudvbUlt1vDjVU4lwL7WJgKkI=; b=MVujzoBEeRcJP/AOLhiPsEDz62VW5HXAwgHIiW7RvxWCEj7I3boqChaYqnLRy/I7d5 HhyVM+Zo13h1YW6ncPMqNQhuoeOMSZfOQ87mFeUi9CSF6QxIw3UGieUMjTrMHTED+G3n h10TisbUEweigGvBPB6qxw9uRJAmDlfAogtfGulEJ8JdvbuhdWRrWHupvCWma1Bpf+Uu vNrJVe0vQOhAmdZyZS4jjlD8DaMuph12ZPwFCg7S06clKnBeL23pzh24je1wReuIja3r Mc1k9nyVHhktH20bqvU+5kF48SEcKG4Y9o8yzXQCA8gIbXdlL+Z3sGSYLPvzqrzJAaaJ PmtA== X-Gm-Message-State: AIVw113tl7dsP/x0UZ2heTLQ3MAPr91wnABCA0+iGqRY1Pmu9XYcPG+4 4CzP913f/P/bdnJf X-Received: by 10.84.129.45 with SMTP id 42mr32062222plb.150.1500321569427; Mon, 17 Jul 2017 12:59:29 -0700 (PDT) Received: from mka.mtv.corp.google.com ([172.22.64.162]) by smtp.gmail.com with ESMTPSA id z67sm95251pgb.58.2017.07.17.12.59.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Jul 2017 12:59:28 -0700 (PDT) From: Matthias Kaehlcke To: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Manasi Navare , rodrigo.vivi@intel.com, clinton.a.taylor@intel.com Date: Mon, 17 Jul 2017 12:58:54 -0700 Message-Id: <20170717195854.192139-1-mka@chromium.org> X-Mailer: git-send-email 2.13.2.932.g7449e964c-goog Cc: Grant Grundler , intel-gfx , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Matthias Kaehlcke Subject: [Intel-gfx] [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. Use the correct table. The error was pointed out by this clang warning: drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") Signed-off-by: Matthias Kaehlcke Reviewed-by: Manasi Navare --- Changes in v2: - Added 'Fixes' tag - Added Reviewed-by: Manasi Navare drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index efb13582dc73..6fa02e6a7a9b 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, if (dev_priv->vbt.edp.low_vswing) { if (voltage == VOLTAGE_INFO_0_85V) { *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V); - return cnl_ddi_translations_dp_0_85V; + return cnl_ddi_translations_edp_0_85V; } else if (voltage == VOLTAGE_INFO_0_95V) { *n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V); return cnl_ddi_translations_edp_0_95V;