From patchwork Wed Jul 26 13:53:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9864877 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CB72A6038C for ; Wed, 26 Jul 2017 13:54:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B0FB328745 for ; Wed, 26 Jul 2017 13:54:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A59AD28770; Wed, 26 Jul 2017 13:54:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1BD5628745 for ; Wed, 26 Jul 2017 13:54:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5EAF6E7AE; Wed, 26 Jul 2017 13:53:59 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83EA86E79F; Wed, 26 Jul 2017 13:53:58 +0000 (UTC) Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0MCuUJ-1dSQPF17nn-009dMt; Wed, 26 Jul 2017 15:53:26 +0200 From: Arnd Bergmann To: dri-devel@lists.freedesktop.org Date: Wed, 26 Jul 2017 15:53:10 +0200 Message-Id: <20170726135312.2214309-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170726135312.2214309-1-arnd@arndb.de> References: <20170726135312.2214309-1-arnd@arndb.de> X-Provags-ID: V03:K0:QvR/cXLZvrvdaTQnSNVuAR59ltdoS1shdkE1TJ5B6hkPeuWy29K H0tWTFyoWxoOVyUFCxmG3vsmFv6j+OhHbLIUbfigP/JYrvG+JES/drGHLR0eX1rEVU9X9CE b83ULdV/S6Ort3Lb8ZEOZXSHKfNokYbDxkNO1F0gULOPTsPA1RiLYxnYZmA2rQ5mb64mTPw 0/DvOoViiT6P/gGhErb3w== X-UI-Out-Filterresults: notjunk:1; V01:K0:NRNBihWZBUQ=:trbsvD6TUnUx4m9Yr9Ulgj Uk4PL0M5xkpPeFnARA4LWXwCf5l2MP4ib+aWJzMJ5J1FBVdtX0osqmhSUk5WL5cAsqJiufBml TVkTzok4uFyBQRVaP1j+QjT0jOoBRSbAdMB1ESysekFFcuD3XqesXVUduZQlJ/Zs+ijPLM7ew WlSL8mNmtVTBQEJAbyvQLYaD+E6XRvAZQes6C6yh3hUM3ai3fwaylQxVdekn7cb8RjQqYBien yY/xQV3FD2UvYsvtro2mslOwf3DS3oHku9enrxtqKGE1WN32UsfsMfR00CqOW/5IBV3uTg+Kr Q2wBbwRU9keivMAsobgGCufNHKkiOdgFqDXBZmVAV9M6CzM5RfeBVdAaowFwM//CUE9jxU9ej fXcEGQ9ogyEgE5qVR+gfGXxMOWXpPUJPtNnCYdDkl45WGHqpdOKU+3hqTVZhSVWa9MFpnV1yl i8aTmfcliIxJlcnsBfLMmClOzzocbRfhTzy+8UJAp6Xpc1A5LX8OV+URaREVDtqMQiZNyxIgP O1z6dWHWcwt9cw1DBpVddGGDI4RNxsA9ELDpZWsnnbXzp1GOR88L9i2hd5NrdUxYFKvCT05hZ 1FvPUYE5NI2dPreThRua6hOddAt4/8bW7Mdqfuiws4rstIn0d6Bi33YCL5QEAUOlhrMvF9Lgj TbwnGYu4KskLS4B+czrsrz6s7KiGuLzAxVMqxnh4eDxsGAnxRhFymx6HX8QQtgJ90NNX1BXQg 4JHpfsxxg3aGIYXTp58x99eTjhmXk5tPgZuIUw== Cc: David Airlie , nouveau@lists.freedesktop.org, Jon Nettleton , platform-driver-x86@vger.kernel.org, Daniel Vetter , devel@driverdev.osuosl.org, Daniel Drake , Jens Frederich , linux-acpi@vger.kernel.org, Ben Skeggs , Russell King , Darren Hart , Len Brown , Arnd Bergmann , intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Andy Shevchenko , Lucas Stach Subject: [Intel-gfx] [PATCH 1/3] backlight: always select BACKLIGHT_LCD_SUPPORT for BACKLIGHT_CLASS_DEVICE X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP randconfig builds occasionally produce this Kconfig warning: warning: (DRM_RADEON && DRM_AMDGPU && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && DRM_FSL_DCU && DRM_TINYDRM && DRM_PARADE_PS8622 && FB_BACKLIGHT && FB_ARMCLCD && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT) It turns out that amost all users of BACKLIGHT_CLASS_DEVICE also select BACKLIGHT_LCD_SUPPORT, but not all of them do. This makes the remaining ones behave like the others. It would probably be best to rework the way those two options related entirely, but for now this takes the simpler and safer approach to fix the warnings without introducing regressions. Signed-off-by: Arnd Bergmann Acked-by: Andy Shevchenko --- drivers/gpu/drm/gma500/Kconfig | 1 + drivers/platform/x86/Kconfig | 2 ++ drivers/staging/olpc_dcon/Kconfig | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig index df11582f1efc..52d855cb0569 100644 --- a/drivers/gpu/drm/gma500/Kconfig +++ b/drivers/gpu/drm/gma500/Kconfig @@ -6,6 +6,7 @@ config DRM_GMA500 # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 select ACPI_VIDEO if ACPI select BACKLIGHT_CLASS_DEVICE if ACPI + select BACKLIGHT_LCD_SUPPORT if ACPI select INPUT if ACPI help Say yes for an experimental 2D KMS framebuffer driver for the diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 80b87954f6dd..e0ca673bf564 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -785,6 +785,7 @@ config ACPI_CMPC depends on RFKILL || RFKILL=n select INPUT select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT default n help Support for Intel Classmate PC ACPI devices, including some @@ -1000,6 +1001,7 @@ config SAMSUNG_Q10 tristate "Samsung Q10 Extras" depends on ACPI select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT ---help--- This driver provides support for backlight control on Samsung Q10 and related laptops, including Dell Latitude X200. diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig index d277f048789e..845f756886f0 100644 --- a/drivers/staging/olpc_dcon/Kconfig +++ b/drivers/staging/olpc_dcon/Kconfig @@ -4,6 +4,7 @@ config FB_OLPC_DCON depends on I2C depends on (GPIO_CS5535 || GPIO_CS5535=n) select BACKLIGHT_CLASS_DEVICE + select BACKLIGHT_LCD_SUPPORT ---help--- In order to support very low power operation, the XO laptop uses a secondary Display CONtroller, or DCON. This secondary controller