diff mbox

[i-g-t,3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

Message ID 20170823152114.16559-3-paul.kocialkowski@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Kocialkowki Aug. 23, 2017, 3:21 p.m. UTC
This adds the fastest chamelium tests to the Intel CI fast-feedback
list, with the objective of running in under a minute.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Paul Kocialkowki Aug. 25, 2017, 12:04 p.m. UTC | #1
On Wed, 2017-08-23 at 18:21 +0300, Paul Kocialkowski wrote:
> This adds the fastest chamelium tests to the Intel CI fast-feedback
> list, with the objective of running in under a minute.

For the record, here are average run times for the added tests:
dp-hpd-fast: 2.397s
dp-edid-read: 1.776s
dp-crc-fast: 6.458s
hdmi-hpd-fast: 2.732s
hdmi-edid-read: 2.165s
hdmi-crc-fast: 8.612s
vga-hpd-fast: 7.384s
vga-edid-read: 3.805s
common-hpd-after-suspend: 22.496s

total: 57.825s

Note that the CRC tests are especially slow because of the interface
decoders on the Chamelium board. They take seconds to detect the video
input as stable and there isn't much we can do about that.

> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> ci/fast-feedback.testlist
> index 79160624..a8e9c5be 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -1,5 +1,14 @@
>  # Keep alphabetically sorted by default
>  
> +igt@chamelium@dp-hpd-fast
> +igt@chamelium@dp-edid-read
> +igt@chamelium@dp-crc-fast
> +igt@chamelium@hdmi-hpd-fast
> +igt@chamelium@hdmi-edid-read
> +igt@chamelium@hdmi-crc-fast
> +igt@chamelium@vga-hpd-fast
> +igt@chamelium@vga-edid-read
> +igt@chamelium@common-hpd-after-suspend
>  igt@core_auth@basic-auth
>  igt@core_prop_blob@basic
>  igt@debugfs_test@read_all_entries
Rodrigo Vivi Aug. 26, 2017, 6:21 a.m. UTC | #2
I have to revert locally to use fast-feedback.testlist here today...
it seems chamelium is not compiling by default...
first I thought it was a dirty build so I
make distclean && autogen && make
and chamelium wasn't still compiled...
I end up not investigating this here, but I can do this next week...
just dropping the message here in case someone has a quick insight...

On Wed, Aug 23, 2017 at 8:21 AM, Paul Kocialkowski
<paul.kocialkowski@linux.intel.com> wrote:
> This adds the fastest chamelium tests to the Intel CI fast-feedback
> list, with the objective of running in under a minute.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 79160624..a8e9c5be 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -1,5 +1,14 @@
>  # Keep alphabetically sorted by default
>
> +igt@chamelium@dp-hpd-fast
> +igt@chamelium@dp-edid-read
> +igt@chamelium@dp-crc-fast
> +igt@chamelium@hdmi-hpd-fast
> +igt@chamelium@hdmi-edid-read
> +igt@chamelium@hdmi-crc-fast
> +igt@chamelium@vga-hpd-fast
> +igt@chamelium@vga-edid-read
> +igt@chamelium@common-hpd-after-suspend
>  igt@core_auth@basic-auth
>  igt@core_prop_blob@basic
>  igt@debugfs_test@read_all_entries
> --
> 2.14.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Paul Kocialkowki Aug. 28, 2017, 7:20 a.m. UTC | #3
Hi,

On Fri, 2017-08-25 at 23:21 -0700, Rodrigo Vivi wrote:
> I have to revert locally to use fast-feedback.testlist here today...
> it seems chamelium is not compiling by default...
> first I thought it was a dirty build so I
> make distclean && autogen && make
> and chamelium wasn't still compiled...
> I end up not investigating this here, but I can do this next week...
> just dropping the message here in case someone has a quick insight...

Chamelium support needs to be explicitely enabled with
--enable-chamelium

The configure script should print whether support for it is enabled or
not in the summary, by the way.

Cheers,

Paul

> On Wed, Aug 23, 2017 at 8:21 AM, Paul Kocialkowski
> <paul.kocialkowski@linux.intel.com> wrote:
> > This adds the fastest chamelium tests to the Intel CI fast-feedback
> > list, with the objective of running in under a minute.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> > ---
> >  tests/intel-ci/fast-feedback.testlist | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > ci/fast-feedback.testlist
> > index 79160624..a8e9c5be 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -1,5 +1,14 @@
> >  # Keep alphabetically sorted by default
> > 
> > +igt@chamelium@dp-hpd-fast
> > +igt@chamelium@dp-edid-read
> > +igt@chamelium@dp-crc-fast
> > +igt@chamelium@hdmi-hpd-fast
> > +igt@chamelium@hdmi-edid-read
> > +igt@chamelium@hdmi-crc-fast
> > +igt@chamelium@vga-hpd-fast
> > +igt@chamelium@vga-edid-read
> > +igt@chamelium@common-hpd-after-suspend
> >  igt@core_auth@basic-auth
> >  igt@core_prop_blob@basic
> >  igt@debugfs_test@read_all_entries
> > --
> > 2.14.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
>
Arkadiusz Hiler Aug. 28, 2017, 7:45 a.m. UTC | #4
On Mon, Aug 28, 2017 at 10:20:23AM +0300, Paul Kocialkowski wrote:
> Hi,
> 
> On Fri, 2017-08-25 at 23:21 -0700, Rodrigo Vivi wrote:
> > I have to revert locally to use fast-feedback.testlist here today...
> > it seems chamelium is not compiling by default...
> > first I thought it was a dirty build so I
> > make distclean && autogen && make
> > and chamelium wasn't still compiled...
> > I end up not investigating this here, but I can do this next week...
> > just dropping the message here in case someone has a quick insight...
> 
> Chamelium support needs to be explicitely enabled with
> --enable-chamelium
> 
> The configure script should print whether support for it is enabled or
> not in the summary, by the way.

Hey,

A sidenote:

If you have a recent piglit you can continue using it with the testlit
using the --ignore-missing switch - the missing tests from the list will
be reported as "notrun" instead of blowing up the runner with
random-looking python exception.


@Petri:
I think we should introduce a switch to './run-tests.sh' to make this
usable through our wrapper. Any thoughts on making this the default
behavior?
diff mbox

Patch

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 79160624..a8e9c5be 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,5 +1,14 @@ 
 # Keep alphabetically sorted by default
 
+igt@chamelium@dp-hpd-fast
+igt@chamelium@dp-edid-read
+igt@chamelium@dp-crc-fast
+igt@chamelium@hdmi-hpd-fast
+igt@chamelium@hdmi-edid-read
+igt@chamelium@hdmi-crc-fast
+igt@chamelium@vga-hpd-fast
+igt@chamelium@vga-edid-read
+igt@chamelium@common-hpd-after-suspend
 igt@core_auth@basic-auth
 igt@core_prop_blob@basic
 igt@debugfs_test@read_all_entries