From patchwork Fri Aug 25 18:26:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9922671 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 242E76022E for ; Fri, 25 Aug 2017 18:26:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 123CB284FC for ; Fri, 25 Aug 2017 18:26:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 01A04284F7; Fri, 25 Aug 2017 18:26:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AAEA428484 for ; Fri, 25 Aug 2017 18:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E9FE6E8D8; Fri, 25 Aug 2017 18:26:51 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id D67436E8D8 for ; Fri, 25 Aug 2017 18:26:49 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 8430773-1500050 for multiple; Fri, 25 Aug 2017 19:26:42 +0100 Received: by haswell.alporthouse.com (sSMTP sendmail emulation); Fri, 25 Aug 2017 19:26:42 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Fri, 25 Aug 2017 19:26:39 +0100 Message-Id: <20170825182639.3004-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170825182150.2907-1-chris@chris-wilson.co.uk> References: <20170825182150.2907-1-chris@chris-wilson.co.uk> X-Originating-IP: 78.156.65.138 X-Country: code=GB country="United Kingdom" ip=78.156.65.138 Subject: [Intel-gfx] [PATCH igt v2] igt/vgem_basic: Load and unload the module first X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP To ensure the module exists, first load it. Then when we try to unload the module (to check that our modprobe interface works), we will not get spurious failures due to -ENOENT (in this case meaning the module did not exist): (vgem_basic:18361) igt-core-DEBUG: Starting subtest: unload (vgem_basic:18361) igt-kmod-DEBUG: Could not remove module vgem (No such file or directory) Test requirement not met in function test_unload, file vgem_basic.c:331: Test requirement: module_unload() == 0 Last errno: 2, No such file or directory Signed-off-by: Chris Wilson Reviewed-by: Petri Latvala --- tests/vgem_basic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/vgem_basic.c b/tests/vgem_basic.c index 982da73a..1a952c54 100644 --- a/tests/vgem_basic.c +++ b/tests/vgem_basic.c @@ -328,6 +328,10 @@ static void test_unload(void) int vgem, dmabuf; uint32_t *ptr; + /* Load and unload vgem just to make sure it exists */ + vgem = __drm_open_driver(DRIVER_VGEM); + igt_require(vgem != -1); + close(vgem); igt_require(module_unload() == 0); vgem = __drm_open_driver(DRIVER_VGEM);