From patchwork Wed Sep 27 09:48:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9973647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EC4C60365 for ; Wed, 27 Sep 2017 09:49:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66C2428F17 for ; Wed, 27 Sep 2017 09:49:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BA9B2913E; Wed, 27 Sep 2017 09:49:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 46B8B28CC0 for ; Wed, 27 Sep 2017 09:49:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B56C06E0BD; Wed, 27 Sep 2017 09:48:58 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 923DB6E14B for ; Wed, 27 Sep 2017 09:48:57 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id m127so11022540wmm.0 for ; Wed, 27 Sep 2017 02:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=J51FNTzkcXD5BCbable94T1TCBK3q/Je/mMBqXAFxGA=; b=GSAIa60dl3pQnVfJ8pIKLHvQlznXjWNZ3DLo4BX98QcK+kMg8KtG0F8okTKXy0BL7h Tm69J26HVUHsWLpYiVJEDg42MFEYpp6/EL8QY2M7JvaMToMJYfVHFGvIRVZ3qurBdPel lw5oQY6UW/WJ9+o0e7kb4HzRXOqU56k2SYFHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=J51FNTzkcXD5BCbable94T1TCBK3q/Je/mMBqXAFxGA=; b=bLLEFjV46dicWE5aUavjbxvHhIkkqPSLuEOOoz1WI+62H2EoWxfWZINxtBVDPwoH3w FMWegUgwDFFa2jw6txhO2fZSahdtgdNpRnOVmGHF0gOXrupSRlLuWm0Mt5HoIELAinZF ZzGdEKsxWQj94VxbudGlBRb6N44HkNBo8iifnk3hkKRPKI5fR5d7uCQdwoRaqFf2JMni 0vHnCrCUAYAk4dtahFXAyhNSefq4YPNH73OMOyxNvYurTzw4F+cqwfOkuGblFomEjGuw 1KKTePGXuDCeELZ62nuDl22LJehc9zJjuJqUwrF+F8CJYR34lUUE3Sj1ypVRYchv2aeA C17A== X-Gm-Message-State: AHPjjUgsH17iVpghdidFhnse5BE0YxDqTUxqYX9zSBpb0GpfA4bRfj9S UnxjX5/poLFKXxtb34JrF6JzsMj1 X-Google-Smtp-Source: AOwi7QB4WH6NwZ7EjEktssivBOUfCiVjTu9ZMdhvYMLkiTwXPyFPSwul0lEWBo0MF9W49L1Q2r26EA== X-Received: by 10.80.129.194 with SMTP id 60mr1206857ede.185.1506505735845; Wed, 27 Sep 2017 02:48:55 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5635:0:39d2:f87e:2033:9f6]) by smtp.gmail.com with ESMTPSA id p14sm6450053edj.21.2017.09.27.02.48.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2017 02:48:55 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Wed, 27 Sep 2017 11:48:48 +0200 Message-Id: <20170927094850.22484-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.14.1 Cc: Jani Nikula , Daniel Vetter , Daniel Vetter , DRI Development , Rodrigo Vivi Subject: [Intel-gfx] [PATCH 1/3] dim: redo the author sob checks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 41dddc0287bb9ef14be8de3c3185ed6aaa809d98 and then tries a different approach because from the commit that originally introduced this: commit 3dd25f235c73f7855dc570585eb2551961a1911a Author: Benjamin Gaignard Date: Wed Jul 26 14:07:49 2017 +0200 dim: add checks for author and committer sign-off-by we have "Use real names for people with many different email addresses." to work around outlook we need to convert the "Last, First" firm into what git expects instead, which also should solve the problem Rodrigo has. Cc: Rodrigo Vivi Cc: Jani Nikula Signed-off-by: Daniel Vetter Acked-by: Rodrigo Vivi --- dim | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 5e8c4d5b212d..4d75c7a7fb0e 100755 --- a/dim +++ b/dim @@ -698,11 +698,13 @@ function checkpatch_commit_push sha1=$1 # use real names for people with many different email addresses - author=$(git show -s $sha1 --format="format:%ae") + author=$(git show -s $sha1 --format="format:%an") committer=$(git show -s $sha1 --format="format:%cn") + # outlook mangles mails into "Last, First" + author_outlook=$(git show -s $sha1 --format="format:%an" | sed -e 's/\([^ ]*\) \(.*\)/\2, \1/') # check for author sign-off - if ! git show -s $sha1 | grep -qi "S.*-by:.*$author" ; then + if ! git show -s $sha1 | grep -qi "S.*-by:.*\\($author\\|$author_outlook\\)" ; then warn_or_fail "$sha1 is lacking author of sign-off" fi