| Message ID | 20171013111137.32692-11-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Michal Wajdeczko (2017-10-13 12:11:33) > diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h > index 5c01849..1d580fa 100644 > --- a/drivers/gpu/drm/i915/intel_uc_fw.h > +++ b/drivers/gpu/drm/i915/intel_uc_fw.h > @@ -27,6 +27,8 @@ > > struct drm_i915_private; > > +#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware" We already have this define in intel_csr.c, so let's reuse it. -Chris
Quoting Chris Wilson (2017-10-13 12:50:53) > Quoting Michal Wajdeczko (2017-10-13 12:11:33) > > diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h > > index 5c01849..1d580fa 100644 > > --- a/drivers/gpu/drm/i915/intel_uc_fw.h > > +++ b/drivers/gpu/drm/i915/intel_uc_fw.h > > @@ -27,6 +27,8 @@ > > > > struct drm_i915_private; > > > > +#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware" > > We already have this define in intel_csr.c, so let's reuse it. Or make it clear in the commit log the duplication is fixed in the next patch. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.c b/drivers/gpu/drm/i915/intel_uc_fw.c index 560fe39..e246dbd 100644 --- a/drivers/gpu/drm/i915/intel_uc_fw.c +++ b/drivers/gpu/drm/i915/intel_uc_fw.c @@ -179,6 +179,8 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n", intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err); + DRM_INFO("%s: Firmware can be downloaded from %s\n", + intel_uc_fw_type_repr(uc_fw->type), INTEL_UC_FIRMWARE_URL); release_firmware(fw); /* OK even if fw is NULL */ } diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h index 5c01849..1d580fa 100644 --- a/drivers/gpu/drm/i915/intel_uc_fw.h +++ b/drivers/gpu/drm/i915/intel_uc_fw.h @@ -27,6 +27,8 @@ struct drm_i915_private; +#define INTEL_UC_FIRMWARE_URL "https://01.org/linuxgraphics/downloads/firmware" + enum intel_uc_fw_status { INTEL_UC_FIRMWARE_FAIL = -1, INTEL_UC_FIRMWARE_NONE = 0,
In case of firmware fetch failure we should help user find latest firmware. Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/intel_uc_fw.c | 2 ++ drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++ 2 files changed, 4 insertions(+)