From patchwork Sun Oct 29 00:20:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rhys Kidd X-Patchwork-Id: 10031191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 19DD060249 for ; Sun, 29 Oct 2017 00:20:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 025C428653 for ; Sun, 29 Oct 2017 00:20:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E75DE28897; Sun, 29 Oct 2017 00:20:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 771AE28653 for ; Sun, 29 Oct 2017 00:20:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E9066E0C8; Sun, 29 Oct 2017 00:20:33 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 951576E0C8 for ; Sun, 29 Oct 2017 00:20:32 +0000 (UTC) Received: by mail-qt0-x243.google.com with SMTP id z28so12473488qtz.13 for ; Sat, 28 Oct 2017 17:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=j3LWp7Z6LNNlU+RobcTS5qCSe+31lsRUJ6Lf1IZBCmA=; b=JyKiQyIzaTxOv53+pUFljt7VaHv8LlLKnE6RirV9w3elwIksC6E1Q+DbATkOvxwc84 1NEfIIfQb8mwz6vaaC/dn7LkQGvdQ+Cefm81Poa5z0MVyGmuJqShsAhwG728ep7NWhde FFmvtYWGBtllyq8jeFFIXwcKZzTG69nON7RMSJD8Yl16BAWvhedbtxrvHMp/GcaSlKuG iS6CvIHMbOxcA/D/hJzdxJv8y1kCXL2pJaHUd6DPxEhhtZ2sklzkhM1LVFu1ohH6N5GX tZKsQ8kQez1a6QPySXjqE2Jbawaaqa96lJygX2SJzUGxikHaNvbNcV2NmONbF6Dkaa6J HRqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j3LWp7Z6LNNlU+RobcTS5qCSe+31lsRUJ6Lf1IZBCmA=; b=Ac5UMEDRlzxJldsaGW7cUoWb+He2Guad6sOWvXlTKd8GljRJ8930L/m7gUmYNIE/zy 96bmz4XbjEfHCDtcxrfW/0nRMwBKVNWaVZEwNmbJZohsPFuHJqQaglRO2FECj3ku1zrU h/0UuJhxTZBmggdKdTAWQT2/01/9lTac1jcNWxmZkEoNm/+OH87stp9E7Ct9+8iIWwFm 8VybjXAbxXi0qz2nCF/ydDegXDWYu7kkJBtXfxLN1286nr03DnXpJp4nu9PYJbkmtSL0 C9mgFrSX7JPebdoN0itjq3fGSpTqYokiR5Zw9bB7/W0KXserqVLojJ2F9ucph4cQEXbv cGuw== X-Gm-Message-State: AMCzsaW5L7xemaj8TNLUkN4HtS91TIjVcnyJE7YBYeUy5BLHkJHSnlIZ duMUAED2JgTMoKUoi/eK8mdJWQ== X-Google-Smtp-Source: ABhQp+QKVDurGpG77desyElhFYTUboD3SQFHwdZtPsU04kroggmKJ8zoD06pThkgVqTfyLuqq84JYw== X-Received: by 10.237.47.195 with SMTP id m61mr7564969qtd.143.1509236431282; Sat, 28 Oct 2017 17:20:31 -0700 (PDT) Received: from xps9560.fios-router.home (pool-108-29-189-134.nycmny.fios.verizon.net. [108.29.189.134]) by smtp.gmail.com with ESMTPSA id e43sm7932311qte.74.2017.10.28.17.20.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Oct 2017 17:20:30 -0700 (PDT) From: Rhys Kidd To: intel-gfx@lists.freedesktop.org Date: Sat, 28 Oct 2017 20:20:18 -0400 Message-Id: <20171029002018.21167-1-rhyskidd@gmail.com> X-Mailer: git-send-email 2.14.1 Cc: Daniel Vetter Subject: [Intel-gfx] [i-g-t] assembler: Fix bashism in run-test.sh X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string, use -n with a normal [ ]. Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI. Also change the script to #!/bin/bash to avoid having to babysit bashism later. Fixes: c3863e19 ("assembler/test: Prep work for meson") CC: Daniel Vetter CC: Petri Latvala Signed-off-by: Rhys Kidd Reviewed-by: Joonas Lahtinen --- assembler/test/run-test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh index 0a5252a8..b5e245bc 100644 --- a/assembler/test/run-test.sh +++ b/assembler/test/run-test.sh @@ -1,11 +1,11 @@ -#!/bin/sh +#!/bin/bash SRCDIR=${srcdir-`pwd`} BUILDDIR=${top_builddir-`pwd`} test="TEST" -if [[ "$1" != "" ]] ; then +if [ -n "$1" ] ; then test="$1" fi