From patchwork Mon Oct 30 13:09:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rhys Kidd X-Patchwork-Id: 10032613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7325960291 for ; Mon, 30 Oct 2017 13:09:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B4A72862B for ; Mon, 30 Oct 2017 13:09:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4EDBD28662; Mon, 30 Oct 2017 13:09:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E35F12862B for ; Mon, 30 Oct 2017 13:09:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 450EE6E183; Mon, 30 Oct 2017 13:09:56 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com [IPv6:2607:f8b0:400d:c0d::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ECBD6E183 for ; Mon, 30 Oct 2017 13:09:55 +0000 (UTC) Received: by mail-qt0-x242.google.com with SMTP id z28so16180790qtz.13 for ; Mon, 30 Oct 2017 06:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Qt2wFdBiBocSlLXfygi2baa3RU6KpfXvfWIsFPxbUEc=; b=T0vYcRaYMh7AfYhqyfC8uMZ2dGmM7WD/fvngJS+idiq8ts9flB9U0iSG6kC+X9+Ud+ CzmHrjKM1amdnOuahB3JnhEHlDQbAmf2Qs6AnL9W/nMxB0nOVdUAKamges8Vz7andCKN mCpY8ElCqPsCMC9ptW5l9pzEH/OapabRmOksnnR+p/JHNXaJKDWkfDt4eDI+z1eSL11a /9VCi7LPyGtO+Xn3UziZxJUnZBEvUsdeoOfCQtPo8aYsesyebgnm6hsp5+l6qcCZeAR2 SRTDrEm6jUZBETTqOVY778lGrL28RIa9Vyv5dT4IyTSmLvgsDxbDWUrUneuyw+UvYSGn gnaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Qt2wFdBiBocSlLXfygi2baa3RU6KpfXvfWIsFPxbUEc=; b=n0JuKp5QBFSK7E9jrtsK4yRkGtfGUagJ40ehjSQF0WNc4fwhn5X1xtPwg7wFnboTu2 rs+djS2kCP4cOOc/7MMFHulEYpoSIXFUew6/JWa2sT4LOwUv7gYWqS0OBK5mYy4mAf3f 4lV73i8zTqHzN//dFF01rRxmcwnBFAkQK1HciGI0ygg3o/4sqid5aGTM7pecG44bG+OX H2GQBsFNV17K4KpcdgZeT5og9/+tSoJw/MwBJyqWIpObsp8ZQulmnH1TH/cnKGrKZf9e vF1cWwZLY3JEPSnWMnv+IRrH8R+B1BDt3eMZLameFDj0D8r109WyAeqCfsJDxH4qpBs3 2Qew== X-Gm-Message-State: AMCzsaXY2yh+vAABjQfcoBh7X9CTJV3VynjFnyYsradTAd8uLvBsPG9A WUhxAgng7/BT5iDnR4McJto7Ng== X-Google-Smtp-Source: ABhQp+TOxNDOch/oiFLtt9itcyhH5NGqYV7OxD/ZcPhrm2dOGIj+5QWHVnolP+5B/Xh5X2M0lc4Wgw== X-Received: by 10.200.17.1 with SMTP id c1mr12895975qtj.252.1509368994280; Mon, 30 Oct 2017 06:09:54 -0700 (PDT) Received: from xps9560.fios-router.home (pool-108-29-189-134.nycmny.fios.verizon.net. [108.29.189.134]) by smtp.gmail.com with ESMTPSA id b37sm9907908qkb.19.2017.10.30.06.09.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2017 06:09:53 -0700 (PDT) From: Rhys Kidd To: intel-gfx@lists.freedesktop.org Date: Mon, 30 Oct 2017 09:09:41 -0400 Message-Id: <20171030130941.24538-1-rhyskidd@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <1509360665.4757.0.camel@linux.intel.com> References: <1509360665.4757.0.camel@linux.intel.com> Cc: Daniel Vetter Subject: [Intel-gfx] [i-g-t v2] assembler: Fix bashism in run-test.sh X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string, use -n with a normal [ ]. Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI. v2: - keep this as a /bin/sh script (Joonas Lahtinen) Fixes: c3863e19 ("assembler/test: Prep work for meson") CC: Daniel Vetter CC: Petri Latvala Reviewed-by: Joonas Lahtinen Signed-off-by: Rhys Kidd --- assembler/test/run-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh index 0a5252a8..b06e1044 100644 --- a/assembler/test/run-test.sh +++ b/assembler/test/run-test.sh @@ -5,7 +5,7 @@ BUILDDIR=${top_builddir-`pwd`} test="TEST" -if [[ "$1" != "" ]] ; then +if [ -n "$1" ] ; then test="$1" fi