| Message ID | 20171101182920.14386-2-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 01, 2017 at 08:29:16PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Throw away the bugs crtc coords vs. fb size check. Crtc coords don't > define the viewport inside the fb, that's a job for the src coords, > which have been checked by the core already. > > Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> > Cc: Sinclair Yeh <syeh@vmware.com> > Cc: Thomas Hellstrom <thellstrom@vmware.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > index 0545740b3724..a4b56699679a 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane, > > vcs = vmw_connector_state_to_vcs(du->connector.state); > > - if ((dest.x2 > new_fb->width || > - dest.y2 > new_fb->height)) { > - DRM_ERROR("CRTC area outside of framebuffer\n"); > - return -EINVAL; > - } > - > /* Only one active implicit framebuffer at a time. */ > mutex_lock(&dev_priv->global_kms_state_mutex); > if (vcs->is_implicit && dev_priv->implicit_fb && > -- > 2.13.6 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Ville, Thank you for the patch. On Wednesday, 1 November 2017 20:29:16 EET Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Throw away the bugs crtc coords vs. fb size check. Crtc coords don't > define the viewport inside the fb, that's a job for the src coords, > which have been checked by the core already. > > Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> > Cc: Sinclair Yeh <syeh@vmware.com> > Cc: Thomas Hellstrom <thellstrom@vmware.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 0545740b3724..a4b56699679a > 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c > @@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane > *plane, > > vcs = vmw_connector_state_to_vcs(du->connector.state); > > - if ((dest.x2 > new_fb->width || > - dest.y2 > new_fb->height)) { > - DRM_ERROR("CRTC area outside of framebuffer\n"); > - return -EINVAL; > - } > - > /* Only one active implicit framebuffer at a time. */ > mutex_lock(&dev_priv->global_kms_state_mutex); > if (vcs->is_implicit && dev_priv->implicit_fb &&
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 0545740b3724..a4b56699679a 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane, vcs = vmw_connector_state_to_vcs(du->connector.state); - if ((dest.x2 > new_fb->width || - dest.y2 > new_fb->height)) { - DRM_ERROR("CRTC area outside of framebuffer\n"); - return -EINVAL; - } - /* Only one active implicit framebuffer at a time. */ mutex_lock(&dev_priv->global_kms_state_mutex); if (vcs->is_implicit && dev_priv->implicit_fb &&