diff mbox

[4/7] drm/i915: fix register naming

Message ID 20171110190845.32574-5-lionel.g.landwerlin@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lionel Landwerlin Nov. 10, 2017, 7:08 p.m. UTC
This name was added with the whitelisting of registers for building up OA
configs. It is contained in a range gen8 whitelist :

   addr >= RPM_CONFIG0.reg && addr <= NOA_CONFIG(8).reg

Hence why the name isn't used anywhere.

v2: Fix register name again RPC->RCP (Matthew)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Matthew Auld Nov. 10, 2017, 7:44 p.m. UTC | #1
On 10 November 2017 at 19:08, Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
> This name was added with the whitelisting of registers for building up OA
> configs. It is contained in a range gen8 whitelist :
>
>    addr >= RPM_CONFIG0.reg && addr <= NOA_CONFIG(8).reg
>
> Hence why the name isn't used anywhere.
>
> v2: Fix register name again RPC->RCP (Matthew)
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Musial, Ewelina Nov. 13, 2017, 7:28 a.m. UTC | #2
On Fri, Nov 10, 2017 at 07:08:42PM +0000, Lionel Landwerlin wrote:
> This name was added with the whitelisting of registers for building up OA
> configs. It is contained in a range gen8 whitelist :
> 
>    addr >= RPM_CONFIG0.reg && addr <= NOA_CONFIG(8).reg
> 
> Hence why the name isn't used anywhere.
> 
> v2: Fix register name again RPC->RCP (Matthew)
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ewelina Musial <ewelina.musial@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 8f3cf50f04b4..f812224d1fc8 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1117,8 +1117,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
>  #define RPM_CONFIG0	    _MMIO(0x0D00)
>  #define RPM_CONFIG1	    _MMIO(0x0D04)
>  
> -/* RPC unit config (Gen8+) */
> -#define RPM_CONFIG	    _MMIO(0x0D08)
> +/* RCP unit config (Gen8+) */
> +#define RCP_CONFIG	    _MMIO(0x0D08)
>  
>  /* NOA (HSW) */
>  #define HSW_MBVID2_NOA0		_MMIO(0x9E80)
> -- 
> 2.15.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8f3cf50f04b4..f812224d1fc8 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1117,8 +1117,8 @@  static inline bool i915_mmio_reg_valid(i915_reg_t reg)
 #define RPM_CONFIG0	    _MMIO(0x0D00)
 #define RPM_CONFIG1	    _MMIO(0x0D04)
 
-/* RPC unit config (Gen8+) */
-#define RPM_CONFIG	    _MMIO(0x0D08)
+/* RCP unit config (Gen8+) */
+#define RCP_CONFIG	    _MMIO(0x0D08)
 
 /* NOA (HSW) */
 #define HSW_MBVID2_NOA0		_MMIO(0x9E80)