| Message ID | 20171127091233.7001-1-joonas.lahtinen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com] > Sent: Monday, November 27, 2017 11:13 AM > To: Intel graphics driver community testing & development <intel- > gfx@lists.freedesktop.org> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Auld, Matthew > <matthew.auld@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Jani > Nikula <jani.nikula@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; > Rantala, Valtteri <valtteri.rantala@intel.com>; Tamminen, Eero T > <eero.t.tamminen@intel.com> > Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A > > We seem to be missing some W/A for 2M pages and are getting a hit on raw > GPU read bandwidths (even 30%) even though the GPU write bandwidths > improve (even 10%). > > For now, disable THP, which is our only practical source of 2M pages until we > have a W/A for the issue. > > v2: > - Be explicit that we talk about GPU bandwidths (Eero) > - s/deny/never/ because that's why (Chris) > > Reported-by: Valtteri Rantala <valtteri.rantala@intel.com> > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP") > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Matthew Auld <matthew.auld@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Valtteri Rantala <valtteri.rantala@intel.com> > Cc: Eero Tamminen <eero.t.tamminen@intel.com> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > Reviewed-by: Matthew Auld <matthew.auld@intel.com> Tested-by: Valtteri Rantala <valtteri.rantala@intel.com> > --- > drivers/gpu/drm/i915/i915_gemfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gemfs.c > b/drivers/gpu/drm/i915/i915_gemfs.c > index e2993857df37..888b7d3f04c3 100644 > --- a/drivers/gpu/drm/i915/i915_gemfs.c > +++ b/drivers/gpu/drm/i915/i915_gemfs.c > @@ -52,7 +52,8 @@ int i915_gemfs_init(struct drm_i915_private *i915) > > if (has_transparent_hugepage()) { > struct super_block *sb = gemfs->mnt_sb; > - char options[] = "huge=within_size"; > + /* FIXME: Disabled until we get W/A for read BW issue. */ > + char options[] = "huge=never"; > int flags = 0; > int err; > > -- > 2.14.3
On Mon, 2017-11-27 at 13:36 +0000, Rantala, Valtteri wrote: > > -----Original Message----- > > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com] > > Sent: Monday, November 27, 2017 11:13 AM > > To: Intel graphics driver community testing & development <intel- > > gfx@lists.freedesktop.org> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Auld, Matthew > > <matthew.auld@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Jani > > Nikula <jani.nikula@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; > > Rantala, Valtteri <valtteri.rantala@intel.com>; Tamminen, Eero T > > <eero.t.tamminen@intel.com> > > Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A > > > > We seem to be missing some W/A for 2M pages and are getting a hit on raw > > GPU read bandwidths (even 30%) even though the GPU write bandwidths > > improve (even 10%). > > > > For now, disable THP, which is our only practical source of 2M pages until we > > have a W/A for the issue. > > > > v2: > > - Be explicit that we talk about GPU bandwidths (Eero) > > - s/deny/never/ because that's why (Chris) > > > > Reported-by: Valtteri Rantala <valtteri.rantala@intel.com> > > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP") > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Matthew Auld <matthew.auld@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Valtteri Rantala <valtteri.rantala@intel.com> > > Cc: Eero Tamminen <eero.t.tamminen@intel.com> > > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > > Reviewed-by: Matthew Auld <matthew.auld@intel.com> > > Tested-by: Valtteri Rantala <valtteri.rantala@intel.com> I'm merging the patch, thanks for the report, reviews and testing! Regards, Joonas
diff --git a/drivers/gpu/drm/i915/i915_gemfs.c b/drivers/gpu/drm/i915/i915_gemfs.c index e2993857df37..888b7d3f04c3 100644 --- a/drivers/gpu/drm/i915/i915_gemfs.c +++ b/drivers/gpu/drm/i915/i915_gemfs.c @@ -52,7 +52,8 @@ int i915_gemfs_init(struct drm_i915_private *i915) if (has_transparent_hugepage()) { struct super_block *sb = gemfs->mnt_sb; - char options[] = "huge=within_size"; + /* FIXME: Disabled until we get W/A for read BW issue. */ + char options[] = "huge=never"; int flags = 0; int err;
We seem to be missing some W/A for 2M pages and are getting a hit on raw GPU read bandwidths (even 30%) even though the GPU write bandwidths improve (even 10%). For now, disable THP, which is our only practical source of 2M pages until we have a W/A for the issue. v2: - Be explicit that we talk about GPU bandwidths (Eero) - s/deny/never/ because that's why (Chris) Reported-by: Valtteri Rantala <valtteri.rantala@intel.com> Fixes: b901bb89324a ("drm/i915/gemfs: enable THP") Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Valtteri Rantala <valtteri.rantala@intel.com> Cc: Eero Tamminen <eero.t.tamminen@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Matthew Auld <matthew.auld@intel.com> --- drivers/gpu/drm/i915/i915_gemfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)