| Message ID | 20171208113933.26384-8-lionel.g.landwerlin@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 8 December 2017 at 11:39, Lionel Landwerlin <lionel.g.landwerlin@intel.com> wrote: > This will enable running the tests on Cannonlake. > > Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Missing the CS timestamp frequency fallback for CNL in get_cs_timestamp_frequency(). Otherwise: Reviewed-by: Matthew Auld <matthew.auld@intel.com>
On 08/12/17 13:50, Matthew Auld wrote: > On 8 December 2017 at 11:39, Lionel Landwerlin > <lionel.g.landwerlin@intel.com> wrote: >> This will enable running the tests on Cannonlake. >> >> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> > Missing the CS timestamp frequency fallback for CNL in > get_cs_timestamp_frequency(). The point is that if we can't read it from the kernel, the tests better fail. It seems like 50% of the parts I've seen so far are clocked like BXT and the other 50% like SKL/KBL. The tests will fail if we run with the wrong assumed frequency. > > Otherwise: > Reviewed-by: Matthew Auld <matthew.auld@intel.com> >
On 08/12/17 13:54, Lionel Landwerlin wrote: > On 08/12/17 13:50, Matthew Auld wrote: >> On 8 December 2017 at 11:39, Lionel Landwerlin >> <lionel.g.landwerlin@intel.com> wrote: >>> This will enable running the tests on Cannonlake. >>> >>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> >> Missing the CS timestamp frequency fallback for CNL in >> get_cs_timestamp_frequency(). > > The point is that if we can't read it from the kernel, the tests > better fail. > It seems like 50% of the parts I've seen so far are clocked like BXT > and the other 50% like SKL/KBL. > The tests will fail if we run with the wrong assumed frequency. Actually I probably want to replace that assert with a skip! > >> >> Otherwise: >> Reviewed-by: Matthew Auld <matthew.auld@intel.com> >> > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/tests/perf.c b/tests/perf.c index cc0c21a1..99bcdc72 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1082,6 +1082,8 @@ init_sys_info(void) igt_debug("unsupported Coffeelake GT size\n"); return false; } + } else if (IS_CANNONLAKE(devid)) { + test_set_uuid = "db41edd4-d8e7-4730-ad11-b9a2d6833503"; } else { igt_debug("unsupported GT\n"); return false;
This will enable running the tests on Cannonlake. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> --- tests/perf.c | 2 ++ 1 file changed, 2 insertions(+)