From patchwork Thu Dec 14 15:43:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marta Lofstedt X-Patchwork-Id: 10112579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A7CCB6019C for ; Thu, 14 Dec 2017 15:43:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99EB129059 for ; Thu, 14 Dec 2017 15:43:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8EC7229555; Thu, 14 Dec 2017 15:43:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 243B329059 for ; Thu, 14 Dec 2017 15:43:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67A046E6CB; Thu, 14 Dec 2017 15:43:04 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF3D86E6CB for ; Thu, 14 Dec 2017 15:43:03 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Dec 2017 07:43:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,400,1508828400"; d="scan'208";a="16003643" Received: from mlofsted-dev-hsw.fi.intel.com (HELO localhost.localdomain) ([10.237.72.167]) by orsmga001.jf.intel.com with ESMTP; 14 Dec 2017 07:42:59 -0800 From: Marta Lofstedt To: intel-gfx@lists.freedesktop.org Date: Thu, 14 Dec 2017 17:43:47 +0200 Message-Id: <20171214154347.25392-1-marta.lofstedt@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [Intel-gfx] [PATCH i-g-t] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The discussion on how to fix the issues has been stagnant for a long time, see the Bugzilla below and: https://patchwork.freedesktop.org/patch/170429/ After only changing display cable the result of my machine went from always failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl flip-flop between pass and WARN and the shard-kbl always fail. This made me realize that the THRESHOLD_PER_CONNECTOR also needed to be updated, while previous discussion only touched the THRESHOLD_TOTAL. As discussed in provided links the motivation for this test is to discover big anomalies in edid timings, but with the current tight thresholds we are hitting the issues too often. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047 Signed-off-by: Marta Lofstedt --- tests/kms_sysfs_edid_timing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c index 12013881..7dbd3fe6 100644 --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -26,8 +26,8 @@ #include #include -#define THRESHOLD_PER_CONNECTOR 10 -#define THRESHOLD_TOTAL 50 +#define THRESHOLD_PER_CONNECTOR 15 +#define THRESHOLD_TOTAL 95 #define CHECK_TIMES 15 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all "