From patchwork Fri Dec 15 13:04:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marta Lofstedt X-Patchwork-Id: 10115037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0C6EF60231 for ; Fri, 15 Dec 2017 13:03:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E09E929F2C for ; Fri, 15 Dec 2017 13:03:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D576529F52; Fri, 15 Dec 2017 13:03:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6B35329F2C for ; Fri, 15 Dec 2017 13:03:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06AAB6E7F6; Fri, 15 Dec 2017 13:03:41 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6F8D6E7F6 for ; Fri, 15 Dec 2017 13:03:39 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 05:03:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="12849074" Received: from mlofsted-dev-hsw.fi.intel.com (HELO localhost.localdomain) ([10.237.72.167]) by fmsmga004.fm.intel.com with ESMTP; 15 Dec 2017 05:03:38 -0800 From: Marta Lofstedt To: intel-gfx@lists.freedesktop.org Date: Fri, 15 Dec 2017 15:04:19 +0200 Message-Id: <20171215130420.12073-2-marta.lofstedt@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171215130420.12073-1-marta.lofstedt@intel.com> References: <20171215130420.12073-1-marta.lofstedt@intel.com> Subject: [Intel-gfx] [PATCH i-g-t v2 1/2] test/kms_sysfs_edid_timing : Increase THRESHOLD_PER_CONNECTOR and THRESHOLD_TOTAL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The discussion on how to fix the issues has been stagnant for a long time, see the Bugzilla below and: https://patchwork.freedesktop.org/patch/170429/ After only changing display cable the result of my machine went from always failing to hit a WARN. This is also illustrated on CI-shards, where the shard-apl flip-flop between pass and WARN and the shard-kbl always fail. This made me realize that the THRESHOLD_PER_CONNECTOR also needed to be updated, while previous discussion only touched the THRESHOLD_TOTAL. As discussed in provided links the motivation for this test is to discover big anomalies in edid timings, but with the current tight thresholds we are hitting the issues too often. V2: increased thresholds further after patchwork results. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100047 Signed-off-by: Marta Lofstedt --- tests/kms_sysfs_edid_timing.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c index 12013881..53d96c1c 100644 --- a/tests/kms_sysfs_edid_timing.c +++ b/tests/kms_sysfs_edid_timing.c @@ -26,8 +26,8 @@ #include #include -#define THRESHOLD_PER_CONNECTOR 10 -#define THRESHOLD_TOTAL 50 +#define THRESHOLD_PER_CONNECTOR 20 +#define THRESHOLD_TOTAL 150 #define CHECK_TIMES 15 IGT_TEST_DESCRIPTION("This check the time we take to read the content of all " @@ -75,21 +75,21 @@ igt_simple_main close(fd); } - igt_debug("%s: mean.max %.2fns, %.2fus, %.2fms, " + igt_info("%s: mean.max %.2fns, %.2fus, %.2fms, " "mean.avg %.2fns, %.2fus, %.2fms\n", de->d_name, mean.max, mean.max / 1e3, mean.max / 1e6, mean.mean, mean.mean / 1e3, mean.mean / 1e6); if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) { - igt_warn("%s: probe time exceed 10ms, " + igt_warn("%s: probe time exceed %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_PER_CONNECTOR, mean.max / 1e6, mean.mean / 1e6); } igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6), - "%s: average probe time exceeded 50ms, " + "%s: average probe time exceeded %ims, " "max=%.2fms, avg=%.2fms\n", de->d_name, - mean.max / 1e6, mean.mean / 1e6); + THRESHOLD_TOTAL, mean.max / 1e6, mean.mean / 1e6); } closedir(dirp);