| Message ID | 20171220183610.23264-9-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Michal Wajdeczko (2017-12-20 18:36:10) > We are dumping device info separately for sw_only and runtime part > but to simplify the code we can also do it from one place once > we complete driver load. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_drv.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 5bf4f58..f3687e5 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -931,12 +931,6 @@ static int i915_driver_init_early(struct drm_i915_private *dev_priv, > > intel_display_crc_init(dev_priv); > > - if (drm_debug & DRM_UT_DRIVER) { > - struct drm_printer p = drm_debug_printer("i915 device info:"); > - > - intel_device_info_dump(&dev_priv->info, &p); > - } > - > intel_detect_preproduction_hw(dev_priv); > > return 0; > @@ -1089,11 +1083,6 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv) > return -ENODEV; > > intel_device_info_runtime_init(mkwrite_device_info(dev_priv)); > - if (drm_debug & DRM_UT_DRIVER) { > - struct drm_printer p = drm_debug_printer("i915 device info:"); > - > - intel_device_info_dump_runtime(&dev_priv->info, &p); > - } > > intel_sanitize_options(dev_priv); > > @@ -1388,6 +1377,13 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent) > > intel_init_ipc(dev_priv); > > + if (drm_debug & DRM_UT_DRIVER) { > + struct drm_printer p = drm_debug_printer("i915 device info:"); > + > + intel_device_info_dump(&dev_priv->info, &p); > + intel_device_info_dump_runtime(&dev_priv->info, &p); > + } Ok. I'd suggest maybe we should move these "welcome messages" to a i915_driver_welcome(). (Or some such.) That will give us a place to add/hook more messages as the need arises. Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 5bf4f58..f3687e5 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -931,12 +931,6 @@ static int i915_driver_init_early(struct drm_i915_private *dev_priv, intel_display_crc_init(dev_priv); - if (drm_debug & DRM_UT_DRIVER) { - struct drm_printer p = drm_debug_printer("i915 device info:"); - - intel_device_info_dump(&dev_priv->info, &p); - } - intel_detect_preproduction_hw(dev_priv); return 0; @@ -1089,11 +1083,6 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv) return -ENODEV; intel_device_info_runtime_init(mkwrite_device_info(dev_priv)); - if (drm_debug & DRM_UT_DRIVER) { - struct drm_printer p = drm_debug_printer("i915 device info:"); - - intel_device_info_dump_runtime(&dev_priv->info, &p); - } intel_sanitize_options(dev_priv); @@ -1388,6 +1377,13 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent) intel_init_ipc(dev_priv); + if (drm_debug & DRM_UT_DRIVER) { + struct drm_printer p = drm_debug_printer("i915 device info:"); + + intel_device_info_dump(&dev_priv->info, &p); + intel_device_info_dump_runtime(&dev_priv->info, &p); + } + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG)) DRM_INFO("DRM_I915_DEBUG enabled\n"); if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM))
We are dumping device info separately for sw_only and runtime part but to simplify the code we can also do it from one place once we complete driver load. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)