| Message ID | 20180320125009.2305-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Daniel Vetter (2018-03-20 12:50:09) > select in Kconfig isn't recursive, we need to select the stuff our > selects select, too. Fix that. Really? That's quite painful. That will limit the usefulness but on the other hand avoid the illegal configurations all over. > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Tue, Mar 20, 2018 at 01:19:01PM +0000, Chris Wilson wrote: > Quoting Daniel Vetter (2018-03-20 12:50:09) > > select in Kconfig isn't recursive, we need to select the stuff our > > selects select, too. Fix that. > > Really? That's quite painful. > > That will limit the usefulness but on the other hand avoid > the illegal configurations all over. Yeah, Kconfig is seriously not an awesome thing :-/ > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Thanks for the review, pushed to dinq. -Daniel
diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index 108d21f34777..dd5bf6389ead 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -25,6 +25,7 @@ config DRM_I915_DEBUG select X86_MSR # used by igt/pm_rpm select DRM_VGEM # used by igt/prime_vgem (dmabuf interop checks) select DRM_DEBUG_MM if DRM=y + select STACKDEPOT if DRM=y # for DRM_DEBUG_MM select DRM_DEBUG_MM_SELFTEST select SW_SYNC # signaling validation framework (igt/syncobj*) select DRM_I915_SW_FENCE_DEBUG_OBJECTS
select in Kconfig isn't recursive, we need to select the stuff our selects select, too. Fix that. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/Kconfig.debug | 1 + 1 file changed, 1 insertion(+)