From patchwork Tue Apr 17 19:02:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 10348055 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CC53B60365 for ; Wed, 18 Apr 2018 12:17:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B955A285E1 for ; Wed, 18 Apr 2018 12:17:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ADFFA285EB; Wed, 18 Apr 2018 12:17:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 86488285E1 for ; Wed, 18 Apr 2018 12:17:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A2E56E080; Wed, 18 Apr 2018 12:17:03 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A9936E4CB for ; Tue, 17 Apr 2018 19:00:11 +0000 (UTC) Received: by mail-pl0-x243.google.com with SMTP id w21-v6so720874plq.2 for ; Tue, 17 Apr 2018 12:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=NsfcLIj2cfbRtLCCKPg5KOOgOCRYV+BXu4l53jxgNM4=; b=QOgLvPzvoKFoRtv9duRIzNZL06NHFFx30CK0s4OglxKtQQfilLpuFWGVSyHJjtXjjp OkZtkSDTRn3XCCVLYyMaDqEu76VjSF/q8dUVbIEOg367tgiX34YD4TnQZvO1Gz9Ya+Gc XTCqWzwaG27GlA+hYNY3pKNrAipyV3VXfheqQCd/BwaJaKejpdaxGJkvXE0fvxze/oeo 3Cj0tgUFcrrx1plowGekDCTwtEkw6/6AltKA2/KrGKRGuqGbWBNQ57YEKS8SS8HuAjJc ZZhJ34S/sbcn/RiGAbNJDBCxtGW3k3Dtuyhse85ygwwBhuRCV3BcY6mbQMSRb3FyEMIu 9ppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=NsfcLIj2cfbRtLCCKPg5KOOgOCRYV+BXu4l53jxgNM4=; b=B59paOAO5SJ3TD0djYC9IUIDCulGhfnKMhn+c78pqGB3qJVJNSMO1ZYgDY4Dk3S12G XTtmkluHS9jpcf0I5BllLmjhxWwDN5IAdkeSNpyHAdtIPXSIxh2nBrR4oNKL3ZS4HlEH 4Tj5O8OaJ1N+SEESfSuuMqJ/LJDJlrmRE4KOK7LvuK24XczMb4uwLaZ74tYUnCpZtPFH aGQa0/h9AOd18QZU3dQ4EXuSv+/ffppjZ5ZlNireeDJBDn8YE1JtwyXF087l6oijjPab MHPtQQ57qQ3b7XjCa1Oxn6FQF79vBXDdVFd7FCUPVuZCcxcKd4Am+AGxfaa2M+a4CfDs sgxA== X-Gm-Message-State: ALQs6tBxB9yMhRIvHd/3ZZKA5lwu5fdcw/JRPNbqEvplV1edgf7TtkzD 8XHEjvYjvb8I8o43Bn108QQw9X1+ X-Google-Smtp-Source: AIpwx48fT6PNm5X01LJxFEIX1jqVmpjxS93WfuvBbOGVTzfPChWa1AcGn8I+sWVZFFvZZ2IvSfck+A== X-Received: by 2002:a17:902:6689:: with SMTP id e9-v6mr3183173plk.176.1523991610350; Tue, 17 Apr 2018 12:00:10 -0700 (PDT) Received: from jordon-HP-15-Notebook-PC ([183.82.18.42]) by smtp.gmail.com with ESMTPSA id b6sm39641141pfm.160.2018.04.17.12.00.07 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Apr 2018 12:00:08 -0700 (PDT) Date: Wed, 18 Apr 2018 00:32:02 +0530 From: Souptick Joarder To: daniel@ffwll.ch, willy@infradead.org, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie Message-ID: <20180417190202.GA22835@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Wed, 18 Apr 2018 12:17:02 +0000 Subject: [Intel-gfx] [PATCH v2] gpu: drm: i915: Change return type to vm_fault_t X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t") Fixed one checkpatch.pl warning inside WARN_ONCE. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_gem.c | 37 +++++++++++++++++++------------------ 2 files changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index a42deeb..95b0d50 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -51,6 +51,7 @@ #include #include #include +#include #include "i915_params.h" #include "i915_reg.h" @@ -3363,7 +3364,7 @@ int i915_gem_wait_for_idle(struct drm_i915_private *dev_priv, unsigned int flags); int __must_check i915_gem_suspend(struct drm_i915_private *dev_priv); void i915_gem_resume(struct drm_i915_private *dev_priv); -int i915_gem_fault(struct vm_fault *vmf); +vm_fault_t i915_gem_fault(struct vm_fault *vmf); int i915_gem_object_wait(struct drm_i915_gem_object *obj, unsigned int flags, long timeout, diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index dd89abd..61816e8 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1882,7 +1882,7 @@ int i915_gem_mmap_gtt_version(void) * The current feature set supported by i915_gem_fault() and thus GTT mmaps * is exposed via I915_PARAM_MMAP_GTT_VERSION (see i915_gem_mmap_gtt_version). */ -int i915_gem_fault(struct vm_fault *vmf) +vm_fault_t i915_gem_fault(struct vm_fault *vmf) { #define MIN_CHUNK_PAGES ((1 << 20) >> PAGE_SHIFT) /* 1 MiB */ struct vm_area_struct *area = vmf->vma; @@ -1894,7 +1894,8 @@ int i915_gem_fault(struct vm_fault *vmf) struct i915_vma *vma; pgoff_t page_offset; unsigned int flags; - int ret; + int error; + vm_fault_t ret; /* We don't use vmf->pgoff since that has the fake offset */ page_offset = (vmf->address - area->vm_start) >> PAGE_SHIFT; @@ -1906,26 +1907,26 @@ int i915_gem_fault(struct vm_fault *vmf) * repeat the flush holding the lock in the normal manner to catch cases * where we are gazumped. */ - ret = i915_gem_object_wait(obj, + error = i915_gem_object_wait(obj, I915_WAIT_INTERRUPTIBLE, MAX_SCHEDULE_TIMEOUT, NULL); - if (ret) + if (error) goto err; - ret = i915_gem_object_pin_pages(obj); - if (ret) + error = i915_gem_object_pin_pages(obj); + if (error) goto err; intel_runtime_pm_get(dev_priv); - ret = i915_mutex_lock_interruptible(dev); - if (ret) + error = i915_mutex_lock_interruptible(dev); + if (error) goto err_rpm; /* Access to snoopable pages through the GTT is incoherent. */ if (obj->cache_level != I915_CACHE_NONE && !HAS_LLC(dev_priv)) { - ret = -EFAULT; + error = -EFAULT; goto err_unlock; } @@ -1952,25 +1953,25 @@ int i915_gem_fault(struct vm_fault *vmf) vma = i915_gem_object_ggtt_pin(obj, &view, 0, 0, PIN_MAPPABLE); } if (IS_ERR(vma)) { - ret = PTR_ERR(vma); + error = PTR_ERR(vma); goto err_unlock; } - ret = i915_gem_object_set_to_gtt_domain(obj, write); - if (ret) + error = i915_gem_object_set_to_gtt_domain(obj, write); + if (error) goto err_unpin; - ret = i915_vma_pin_fence(vma); - if (ret) + error = i915_vma_pin_fence(vma); + if (error) goto err_unpin; /* Finally, remap it using the new GTT offset */ - ret = remap_io_mapping(area, + error = remap_io_mapping(area, area->vm_start + (vma->ggtt_view.partial.offset << PAGE_SHIFT), (ggtt->gmadr.start + vma->node.start) >> PAGE_SHIFT, min_t(u64, vma->size, area->vm_end - area->vm_start), &ggtt->iomap); - if (ret) + if (error) goto err_fence; /* Mark as being mmapped into userspace for later revocation */ @@ -1991,7 +1992,7 @@ int i915_gem_fault(struct vm_fault *vmf) intel_runtime_pm_put(dev_priv); i915_gem_object_unpin_pages(obj); err: - switch (ret) { + switch (error) { case -EIO: /* * We eat errors when the gpu is terminally wedged to avoid @@ -2027,7 +2028,7 @@ int i915_gem_fault(struct vm_fault *vmf) ret = VM_FAULT_SIGBUS; break; default: - WARN_ONCE(ret, "unhandled error in i915_gem_fault: %i\n", ret); + WARN_ONCE(ret, "unhandled error in %s: %x\n", __func__, ret); ret = VM_FAULT_SIGBUS; break; }