From patchwork Wed May 2 08:23:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10375225 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3747C6037D for ; Wed, 2 May 2018 08:24:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24EFC25D99 for ; Wed, 2 May 2018 08:24:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19CB828C6A; Wed, 2 May 2018 08:24:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A032A25D99 for ; Wed, 2 May 2018 08:24:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A73326E528; Wed, 2 May 2018 08:24:08 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id B27B56E527 for ; Wed, 2 May 2018 08:24:06 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id a67so13629132wmf.3 for ; Wed, 02 May 2018 01:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N88gPgyl5jC9NcLEIGgq3bKtMDYz9et9YD6a0wRq7XE=; b=RuanaXBrDAhSI6+kjLkdGnWwWC1esQoO8rox1hKMgCuzqk1oPd5VKFcqaNAUOnuV4L ydunqwJxrYWFn4hN2S8YTwxrs3MvxXqwb7sMAs9YViVY/XMxO3WhmiddiWwelHr4gXEF x3P0ZpEFSDUwo6RSvskAiyhsXc2u4QjVGPal8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N88gPgyl5jC9NcLEIGgq3bKtMDYz9et9YD6a0wRq7XE=; b=qhwu0aNdnrU4mtlLVAgKCYjixnr4YAMzdnPXBdpzjbpIw9e0Kzd7cDydMhjkInK4Ku WGrfO0TmUzSOP2lpLyusOO53wbHmxR9GaQFDfTvBg5/btPKUWiaS5cwF8n+CqJcX1B5T w+SjDF0AcKoZy1JG0oGVwyIgqQy5Dy2hJOlZGUpvu7587hp7FDS0WclOhq0AVCXKQC6l sNkS63NFi+QLm/v1JEM+a+EHg8UojwwqHgpSXGxgjMhTbj++xviaXRgD+ITzMDf/KbaC 8PRDz3mR2R7vltCLgACziOBrb5IOOxSjQEoxGHMK93BKuDYzFbu6KWH5zTkxM8LaUTZO xtdA== X-Gm-Message-State: ALQs6tDA0YJEAtYZvAF3CZOK8YmoVJkiNrBfihiYVC0/nCnrUqxQfkgr DaI7GzyjtQgrdehRd523evfoQA== X-Google-Smtp-Source: AB8JxZpfCdZkK0top5niY/biIsgnPTiAZm4chGr1WJ/cDy9cFdOB2hHbpQahTecSp71vR5Wt6qeleA== X-Received: by 2002:a50:a3e5:: with SMTP id t34-v6mr24534696edb.227.1525249445446; Wed, 02 May 2018 01:24:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5635:0:39d2:f87e:2033:9f6]) by smtp.gmail.com with ESMTPSA id l1-v6sm6360392edi.54.2018.05.02.01.24.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 May 2018 01:24:04 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Wed, 2 May 2018 10:23:59 +0200 Message-Id: <20180502082359.30345-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427061724.28497-3-daniel.vetter@ffwll.ch> References: <20180427061724.28497-3-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] dma-fence: remove fill_driver_data callback X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , =?UTF-8?q?Christian=20K=C3=B6nig?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Noticed while I was typing docs. Entirely unused. v2: Remove reference in @timeline_value_str too. While at it clarify why timeline_value_str has a fence parameter - we don't have an explicit timeline structure unfortunately. Cc: Eric Anholt Reviewed-by: Christian König (v1) Cc: Christian König (v1) Signed-off-by: Daniel Vetter Reviewed-by: Eric Anholt --- include/linux/dma-fence.h | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index eb9b05aa5aea..111aefe1c956 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -217,17 +217,6 @@ struct dma_fence_ops { */ void (*release)(struct dma_fence *fence); - /** - * @fill_driver_data: - * - * Callback to fill in free-form debug info. - * - * Returns amount of bytes filled, or negative error on failure. - * - * This callback is optional. - */ - int (*fill_driver_data)(struct dma_fence *fence, void *data, int size); - /** * @fence_value_str: * @@ -242,8 +231,9 @@ struct dma_fence_ops { * @timeline_value_str: * * Fills in the current value of the timeline as a string, like the - * sequence number. This should match what @fill_driver_data prints for - * the most recently signalled fence (assuming no delayed signalling). + * sequence number. Note that the specific fence passed to this function + * should not matter, drivers should only use it to look up the + * corresponding timeline structures. */ void (*timeline_value_str)(struct dma_fence *fence, char *str, int size);