| Message ID | 20180511195145.3829-3-dhinakaran.pandiyan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 11 May 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote: > Entry corresponding to 220 us setup time was missing. I am not aware of > any specific bug this fixes, but this could potentially result in enabling > PSR on a panel with a higher setup time requirement than supported by the > hardware. > > I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a. > > Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") > Cc: stable@vger.kernel.org > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Jose Roberto de Souza <jose.souza@intel.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Pushed to drm-misc-fixes with reviews picked up from the earlier posting [1]. Doesn't look like the function is used by anyone other than i915, so I didn't bother with further acks from non-Intel devs. Should be a straightforward fix anyway. BR, Jani. [1] http://mid.mail-archive.com/20180511005419.11199-1-dhinakaran.pandiyan@intel.com > --- > drivers/gpu/drm/drm_dp_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 36c7609a4bd5..a7ba602a43a8 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) > static const u16 psr_setup_time_us[] = { > PSR_SETUP_TIME(330), > PSR_SETUP_TIME(275), > + PSR_SETUP_TIME(220), > PSR_SETUP_TIME(165), > PSR_SETUP_TIME(110), > PSR_SETUP_TIME(55),
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 36c7609a4bd5..a7ba602a43a8 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]) static const u16 psr_setup_time_us[] = { PSR_SETUP_TIME(330), PSR_SETUP_TIME(275), + PSR_SETUP_TIME(220), PSR_SETUP_TIME(165), PSR_SETUP_TIME(110), PSR_SETUP_TIME(55),
Entry corresponding to 220 us setup time was missing. I am not aware of any specific bug this fixes, but this could potentially result in enabling PSR on a panel with a higher setup time requirement than supported by the hardware. I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a. Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()") Cc: stable@vger.kernel.org Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Jose Roberto de Souza <jose.souza@intel.com> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+)