diff mbox

drm/i915/icl: Don't update enabled dbuf slices struct until updated in hw

Message ID 20180517132626.5885-1-mahesh1.kumar@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kumar, Mahesh May 17, 2018, 1:26 p.m. UTC
Do not update number of enabled dbuf slices in dev_priv struct until we
actually enable/disable dbuf slice in hw. This is leading to never
updating dbuf slices and resulting in DBuf slice mismatch warning.

Fixes: aa9664ffe863 ("drm/i915/icl: Enable 2nd DBuf slice only when needed")
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Zanoni, Paulo R June 4, 2018, 11:49 p.m. UTC | #1
Em Qui, 2018-05-17 às 18:56 +0530, Mahesh Kumar escreveu:
> Do not update number of enabled dbuf slices in dev_priv struct until
> we
> actually enable/disable dbuf slice in hw. This is leading to never
> updating dbuf slices and resulting in DBuf slice mismatch warning.
> 
> Fixes: aa9664ffe863 ("drm/i915/icl: Enable 2nd DBuf slice only when
> needed")
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'll merge it.

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index b85229e153c4..53aaaa3e6886 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5150,7 +5150,6 @@ skl_copy_ddb_for_pipe(struct skl_ddb_values
> *dst,
>  	       sizeof(dst->ddb.uv_plane[pipe]));
>  	memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
>  	       sizeof(dst->ddb.plane[pipe]));
> -	dst->ddb.enabled_slices = src->ddb.enabled_slices;
>  }
>  
>  static void
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index b85229e153c4..53aaaa3e6886 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5150,7 +5150,6 @@  skl_copy_ddb_for_pipe(struct skl_ddb_values *dst,
 	       sizeof(dst->ddb.uv_plane[pipe]));
 	memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
 	       sizeof(dst->ddb.plane[pipe]));
-	dst->ddb.enabled_slices = src->ddb.enabled_slices;
 }
 
 static void