diff mbox

[v2,02/13] drm/i915: Fix tabs vs. spaces

Message ID 20180530165933.11424-3-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ville Syrjälä May 30, 2018, 4:59 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The sprite code has a bunch of spaces where tabs should be used. Fix it
up.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_sprite.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Jani Nikula May 31, 2018, 6:13 a.m. UTC | #1 
On Wed, 30 May 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The sprite code has a bunch of spaces where tabs should be used. Fix it
> up.

I guess the subject could be a little more specific; you aren't fixing
the whole driver after all. With that,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index ee23613f9fd4..b056a74300c8 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1303,8 +1303,8 @@ static bool skl_mod_supported(uint32_t format, uint64_t modifier)
>  }
>  
>  static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
> -                                                    uint32_t format,
> -                                                    uint64_t modifier)
> +						    uint32_t format,
> +						    uint64_t modifier)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(plane->dev);
>  
> @@ -1326,14 +1326,14 @@ static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
>  }
>  
>  static const struct drm_plane_funcs intel_sprite_plane_funcs = {
> -        .update_plane = drm_atomic_helper_update_plane,
> -        .disable_plane = drm_atomic_helper_disable_plane,
> -        .destroy = intel_plane_destroy,
> -        .atomic_get_property = intel_plane_atomic_get_property,
> -        .atomic_set_property = intel_plane_atomic_set_property,
> -        .atomic_duplicate_state = intel_plane_duplicate_state,
> -        .atomic_destroy_state = intel_plane_destroy_state,
> -        .format_mod_supported = intel_sprite_plane_format_mod_supported,
> +	.update_plane = drm_atomic_helper_update_plane,
> +	.disable_plane = drm_atomic_helper_disable_plane,
> +	.destroy = intel_plane_destroy,
> +	.atomic_get_property = intel_plane_atomic_get_property,
> +	.atomic_set_property = intel_plane_atomic_set_property,
> +	.atomic_duplicate_state = intel_plane_duplicate_state,
> +	.atomic_destroy_state = intel_plane_destroy_state,
> +	.format_mod_supported = intel_sprite_plane_format_mod_supported,
>  };
>  
>  bool skl_plane_has_ccs(struct drm_i915_private *dev_priv,
Ville Syrjälä June 1, 2018, 3:54 p.m. UTC | #2 
On Thu, May 31, 2018 at 09:13:12AM +0300, Jani Nikula wrote:
> On Wed, 30 May 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The sprite code has a bunch of spaces where tabs should be used. Fix it
> > up.
> 
> I guess the subject could be a little more specific; you aren't fixing
> the whole driver after all. With that,
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Patch subject amanded and pushed to dinq. Alas I forgot that I had
already pushed something to drm-misc-next which made this patch
redundant. So in hindsight I should have just dropped this one and
avoided the merge conflicts. Thanks for the review anyway.

> 
> 
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_sprite.c | 20 ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index ee23613f9fd4..b056a74300c8 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1303,8 +1303,8 @@ static bool skl_mod_supported(uint32_t format, uint64_t modifier)
> >  }
> >  
> >  static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
> > -                                                    uint32_t format,
> > -                                                    uint64_t modifier)
> > +						    uint32_t format,
> > +						    uint64_t modifier)
> >  {
> >  	struct drm_i915_private *dev_priv = to_i915(plane->dev);
> >  
> > @@ -1326,14 +1326,14 @@ static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
> >  }
> >  
> >  static const struct drm_plane_funcs intel_sprite_plane_funcs = {
> > -        .update_plane = drm_atomic_helper_update_plane,
> > -        .disable_plane = drm_atomic_helper_disable_plane,
> > -        .destroy = intel_plane_destroy,
> > -        .atomic_get_property = intel_plane_atomic_get_property,
> > -        .atomic_set_property = intel_plane_atomic_set_property,
> > -        .atomic_duplicate_state = intel_plane_duplicate_state,
> > -        .atomic_destroy_state = intel_plane_destroy_state,
> > -        .format_mod_supported = intel_sprite_plane_format_mod_supported,
> > +	.update_plane = drm_atomic_helper_update_plane,
> > +	.disable_plane = drm_atomic_helper_disable_plane,
> > +	.destroy = intel_plane_destroy,
> > +	.atomic_get_property = intel_plane_atomic_get_property,
> > +	.atomic_set_property = intel_plane_atomic_set_property,
> > +	.atomic_duplicate_state = intel_plane_duplicate_state,
> > +	.atomic_destroy_state = intel_plane_destroy_state,
> > +	.format_mod_supported = intel_sprite_plane_format_mod_supported,
> >  };
> >  
> >  bool skl_plane_has_ccs(struct drm_i915_private *dev_priv,
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index ee23613f9fd4..b056a74300c8 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1303,8 +1303,8 @@  static bool skl_mod_supported(uint32_t format, uint64_t modifier)
 }
 
 static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
-                                                    uint32_t format,
-                                                    uint64_t modifier)
+						    uint32_t format,
+						    uint64_t modifier)
 {
 	struct drm_i915_private *dev_priv = to_i915(plane->dev);
 
@@ -1326,14 +1326,14 @@  static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane,
 }
 
 static const struct drm_plane_funcs intel_sprite_plane_funcs = {
-        .update_plane = drm_atomic_helper_update_plane,
-        .disable_plane = drm_atomic_helper_disable_plane,
-        .destroy = intel_plane_destroy,
-        .atomic_get_property = intel_plane_atomic_get_property,
-        .atomic_set_property = intel_plane_atomic_set_property,
-        .atomic_duplicate_state = intel_plane_duplicate_state,
-        .atomic_destroy_state = intel_plane_destroy_state,
-        .format_mod_supported = intel_sprite_plane_format_mod_supported,
+	.update_plane = drm_atomic_helper_update_plane,
+	.disable_plane = drm_atomic_helper_disable_plane,
+	.destroy = intel_plane_destroy,
+	.atomic_get_property = intel_plane_atomic_get_property,
+	.atomic_set_property = intel_plane_atomic_set_property,
+	.atomic_duplicate_state = intel_plane_duplicate_state,
+	.atomic_destroy_state = intel_plane_destroy_state,
+	.format_mod_supported = intel_sprite_plane_format_mod_supported,
 };
 
 bool skl_plane_has_ccs(struct drm_i915_private *dev_priv,