diff mbox

[i-g-t] perf_pmu: Stop skipping hotplug test on Broxton

Message ID 20180531112026.17497-1-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin May 31, 2018, 11:20 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

There is a chance new kernel or new firmware fixed the CPU0 hotplug hang
issue. Remove the skip to check if that's true.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 tests/perf_pmu.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Saarinen, Jani June 1, 2018, 6:17 a.m. UTC | #1
> -----Original Message-----

> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of

> Tvrtko Ursulin

> Sent: torstai 31. toukokuuta 2018 14.20

> To: igt-dev@lists.freedesktop.org

> Cc: intel-gfx@lists.freedesktop.org; Ursulin, Tvrtko <tvrtko.ursulin@intel.com>

> Subject: [igt-dev] [PATCH i-g-t] perf_pmu: Stop skipping hotplug test on Broxton

> 

> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

> 

> There is a chance new kernel or new firmware fixed the CPU0 hotplug hang

> issue. Remove the skip to check if that's true.

Based on trybot and this run on shards
Not sure if it was BIOS or BIOS+latest tip but,

Acked-by: Jani Saarinen <jani.saarinen@intel.com>


> 

> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

> ---

>  tests/perf_pmu.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c index

> 9af192dd8232..4570f926d7fe 100644

> --- a/tests/perf_pmu.c

> +++ b/tests/perf_pmu.c

> @@ -1037,7 +1037,6 @@ static void cpu_hotplug(int gem_fd)

>  	int cur = 0;

>  	char buf;

> 

> -	igt_skip_on(IS_BROXTON(intel_get_drm_devid(gem_fd)));

>  	igt_require(cpu0_hotplug_support());

> 

>  	fd =

> open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));

> --

> 2.17.0

> 

> _______________________________________________

> igt-dev mailing list

> igt-dev@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Tvrtko Ursulin June 1, 2018, 8:18 a.m. UTC | #2
On 01/06/2018 07:17, Saarinen, Jani wrote:
> 
> 
>> -----Original Message-----
>> From: igt-dev [mailto:igt-dev-bounces@lists.freedesktop.org] On Behalf Of
>> Tvrtko Ursulin
>> Sent: torstai 31. toukokuuta 2018 14.20
>> To: igt-dev@lists.freedesktop.org
>> Cc: intel-gfx@lists.freedesktop.org; Ursulin, Tvrtko <tvrtko.ursulin@intel.com>
>> Subject: [igt-dev] [PATCH i-g-t] perf_pmu: Stop skipping hotplug test on Broxton
>>
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> There is a chance new kernel or new firmware fixed the CPU0 hotplug hang
>> issue. Remove the skip to check if that's true.
> Based on trybot and this run on shards
> Not sure if it was BIOS or BIOS+latest tip but,
> 
> Acked-by: Jani Saarinen <jani.saarinen@intel.com>

Thanks, pushed!

Regards,

Tvrtko
diff mbox

Patch

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 9af192dd8232..4570f926d7fe 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1037,7 +1037,6 @@  static void cpu_hotplug(int gem_fd)
 	int cur = 0;
 	char buf;
 
-	igt_skip_on(IS_BROXTON(intel_get_drm_devid(gem_fd)));
 	igt_require(cpu0_hotplug_support());
 
 	fd = open_pmu(I915_PMU_ENGINE_BUSY(I915_ENGINE_CLASS_RENDER, 0));