| Message ID | 20180531115624.30269-2-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/31/2018 07:56 PM, Jani Nikula wrote: > Virtualized non-PCH systems such as Broxton or Geminilake should use > PCH_NONE to indicate no PCH rather than PCH_NOP. The latter is a > specific case to indicate a PCH system without south display. > > Reported-by: Colin Xu <Colin.Xu@intel.com> > Cc: Colin Xu <Colin.Xu@intel.com> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 8f002ae22e62..c42e389a27f3 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -287,7 +287,7 @@ static void intel_detect_pch(struct drm_i915_private *dev_priv) > if (WARN_ON(pch_type == PCH_NONE)) > pch_type = PCH_NOP; > } else { > - pch_type = PCH_NOP; > + pch_type = PCH_NONE; > } > dev_priv->pch_type = pch_type; > dev_priv->pch_id = id; Tested on BXT gvt-g and got expected behaviour. Tested-by: Colin Xu <Colin.Xu@intel.com> Reviewed-by: Colin Xu <Colin.Xu@intel.com>
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 8f002ae22e62..c42e389a27f3 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -287,7 +287,7 @@ static void intel_detect_pch(struct drm_i915_private *dev_priv) if (WARN_ON(pch_type == PCH_NONE)) pch_type = PCH_NOP; } else { - pch_type = PCH_NOP; + pch_type = PCH_NONE; } dev_priv->pch_type = pch_type; dev_priv->pch_id = id;