| Message ID | 20180614201419.13300-2-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Chris Wilson (2018-06-14 23:14:19) > We believe we have all the kinks worked out, even for the early > Valleyview devices, for whom we currently disable all ppgtt. > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> For the rather limited scope of the patch, can you Ville give a Tested-by? Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Regards, Joonas
On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote: > Quoting Chris Wilson (2018-06-14 23:14:19) > > We believe we have all the kinks worked out, even for the early > > Valleyview devices, for whom we currently disable all ppgtt. > > > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > For the rather limited scope of the patch, can you Ville give a Tested-by? Not sure I want to trust the B0 results quite that far. > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Regards, Joonas
Quoting Ville Syrjälä (2018-06-15 14:54:39) > On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote: > > Quoting Chris Wilson (2018-06-14 23:14:19) > > > We believe we have all the kinks worked out, even for the early > > > Valleyview devices, for whom we currently disable all ppgtt. > > > > > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > > For the rather limited scope of the patch, can you Ville give a Tested-by? > > Not sure I want to trust the B0 results quite that far. But perhaps an ack? :) -Chris
On Fri, Jun 15, 2018 at 02:57:32PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-06-15 14:54:39) > > On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote: > > > Quoting Chris Wilson (2018-06-14 23:14:19) > > > > We believe we have all the kinks worked out, even for the early > > > > Valleyview devices, for whom we currently disable all ppgtt. > > > > > > > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > > > > > For the rather limited scope of the patch, can you Ville give a Tested-by? > > > > Not sure I want to trust the B0 results quite that far. > > But perhaps an ack? :) Sure Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Hopefully we'll get the B2 soon to verify the results.
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 5ef5176e10fe..dbc55ae234ac 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -173,12 +173,6 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv, return 0; } - /* Early VLV doesn't have this */ - if (IS_VALLEYVIEW(dev_priv) && dev_priv->drm.pdev->revision < 0xb) { - DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n"); - return 0; - } - if (has_full_48bit_ppgtt) return 3;
We believe we have all the kinks worked out, even for the early Valleyview devices, for whom we currently disable all ppgtt. References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ------ 1 file changed, 6 deletions(-)