From patchwork Tue Jun 19 10:49:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 10474025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4B4556029B for ; Tue, 19 Jun 2018 10:49:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 346C0286C1 for ; Tue, 19 Jun 2018 10:49:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 28BAA28A69; Tue, 19 Jun 2018 10:49:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D9399286C1 for ; Tue, 19 Jun 2018 10:49:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C7636E500; Tue, 19 Jun 2018 10:49:35 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB37F6E4FE; Tue, 19 Jun 2018 10:49:33 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 12091677-1500050 for multiple; Tue, 19 Jun 2018 11:49:26 +0100 Received: by haswell.alporthouse.com (sSMTP sendmail emulation); Tue, 19 Jun 2018 11:49:25 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Tue, 19 Jun 2018 11:49:17 +0100 Message-Id: <20180619104920.17528-3-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.18.0.rc2 In-Reply-To: <20180619104920.17528-1-chris@chris-wilson.co.uk> References: <20180619104920.17528-1-chris@chris-wilson.co.uk> X-Originating-IP: 78.156.65.138 X-Country: code=GB country="United Kingdom" ip=78.156.65.138 Subject: [Intel-gfx] [PATCH i-g-t 3/6] igt/gem_sync: Double the wakeups, twice the pain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP To further defeat any contemplated spin-optimisations to avoid the irq latency for synchronous wakeups, increase the queue length. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- tests/gem_sync.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/gem_sync.c b/tests/gem_sync.c index 4cd97c58b..5901e1476 100644 --- a/tests/gem_sync.c +++ b/tests/gem_sync.c @@ -178,7 +178,7 @@ idle_ring(int fd, unsigned ring, int timeout) } static void -wakeup_ring(int fd, unsigned ring, int timeout) +wakeup_ring(int fd, unsigned ring, int timeout, int wlen) { unsigned engines[16]; const char *names[16]; @@ -240,7 +240,8 @@ wakeup_ring(int fd, unsigned ring, int timeout) while (!READ_ONCE(*spin->running)) ; - gem_execbuf(fd, &execbuf); + for (int n = 0; n < wlen; n++) + gem_execbuf(fd, &execbuf); this = gettime(); igt_spin_batch_end(spin); @@ -849,7 +850,9 @@ igt_main igt_subtest_f("idle-%s", e->name) idle_ring(fd, e->exec_id | e->flags, 150); igt_subtest_f("wakeup-%s", e->name) - wakeup_ring(fd, e->exec_id | e->flags, 150); + wakeup_ring(fd, e->exec_id | e->flags, 150, 1); + igt_subtest_f("double-wakeup-%s", e->name) + wakeup_ring(fd, e->exec_id | e->flags, 150, 2); igt_subtest_f("store-%s", e->name) store_ring(fd, e->exec_id | e->flags, 1, 150); igt_subtest_f("many-%s", e->name) @@ -871,7 +874,9 @@ igt_main igt_subtest("forked-store-each") store_ring(fd, ALL_ENGINES, ncpus, 150); igt_subtest("wakeup-each") - wakeup_ring(fd, ALL_ENGINES, 150); + wakeup_ring(fd, ALL_ENGINES, 150, 1); + igt_subtest("double-wakeup-each") + wakeup_ring(fd, ALL_ENGINES, 150, 2); igt_subtest("basic-all") sync_all(fd, 1, 5);