From patchwork Mon Jun 25 17:25:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 10487065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B592060230 for ; Mon, 25 Jun 2018 17:25:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D0D6285A5 for ; Mon, 25 Jun 2018 17:25:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 907B1285A9; Mon, 25 Jun 2018 17:25:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 414E2285A4 for ; Mon, 25 Jun 2018 17:25:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1609F6E199; Mon, 25 Jun 2018 17:25:55 +0000 (UTC) X-Original-To: Intel-gfx@lists.freedesktop.org Delivered-To: Intel-gfx@lists.freedesktop.org Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16BB66E199 for ; Mon, 25 Jun 2018 17:25:53 +0000 (UTC) Received: by mail-wr0-x243.google.com with SMTP id k16-v6so14506134wro.0 for ; Mon, 25 Jun 2018 10:25:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OxvRGs4GWFy+/vBThlfbr9AuRduHNaI+eWyzv0S9lhU=; b=BnAnM9AiWcRCyIdNhVBimvUH2Aair09LbuzEgR4Nde6fjBLTcWQCJIGE3DY/GSbw8R WQkF2vs9cAR/ynXsztqMl+6Cbhl2AwwBtuV/W7yd7wL+wl+yr0fuJk7YDiPkcm/gROfk baEXdmZnv6B5A/kS11b1Fp3few+eb6twea7OyIDFqDLHchVcGbbWT2zxPtDDIb6+MDr3 atc5O/EVVGxjFoYtBfBMDsomwlhr0z37rRtU5WVa9h9msm9M0X2c5eK2RBa+3vgFYfRt NFd6DuloeJK8k+GfIsyo5RsLxT4DoywvsJO1PbOfDgtuyFjJLStgWGIm0VvccZlfU7Oq MeWg== X-Gm-Message-State: APt69E3GLuDQsl12Sj55kFBWpmy4PNCI2XG3KoCDlD24l2wPCbZMpCpz /xvnPEocZP0i9F2FEqJC3ZKMAY8O X-Google-Smtp-Source: AAOMgpfbrCy1thRIC8NoRnURnU7Lfr4cS9ofw0kWHqQG8pH4u8YVmNyrlH5ergkcAonEwVl9DrXAJQ== X-Received: by 2002:adf:b690:: with SMTP id j16-v6mr11253806wre.200.1529947551563; Mon, 25 Jun 2018 10:25:51 -0700 (PDT) Received: from localhost.localdomain ([95.146.151.144]) by smtp.gmail.com with ESMTPSA id c18-v6sm27849800wrq.17.2018.06.25.10.25.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 10:25:51 -0700 (PDT) From: Tvrtko Ursulin X-Google-Original-From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org Date: Mon, 25 Jun 2018 18:25:45 +0100 Message-Id: <20180625172546.7729-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.17.1 Subject: [Intel-gfx] [PATCH 1/2] drm/i915/tracepoints: Remove i915_request_execute tracepoint X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP From: Tvrtko Ursulin Long time ago execute was a fence and it made sense to have a tracepoint corresponding to it. Nowadays it completely aligns either with request_ submit or request_in tracepoints and so is redundant. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 2 -- drivers/gpu/drm/i915/i915_trace.h | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index e1dbb544046f..8217e19542d9 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -541,8 +541,6 @@ void __i915_request_submit(struct i915_request *request) /* Transfer from per-context onto the global per-engine timeline */ move_to_timeline(request, &engine->timeline); - trace_i915_request_execute(request); - wake_up_all(&request->execute); } diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h index b50c6b829715..4a6a15075afa 100644 --- a/drivers/gpu/drm/i915/i915_trace.h +++ b/drivers/gpu/drm/i915/i915_trace.h @@ -685,11 +685,6 @@ DEFINE_EVENT(i915_request, i915_request_submit, TP_ARGS(rq) ); -DEFINE_EVENT(i915_request, i915_request_execute, - TP_PROTO(struct i915_request *rq), - TP_ARGS(rq) -); - TRACE_EVENT(i915_request_in, TP_PROTO(struct i915_request *rq, unsigned int port), TP_ARGS(rq, port), @@ -763,11 +758,6 @@ trace_i915_request_submit(struct i915_request *rq) { } -static inline void -trace_i915_request_execute(struct i915_request *rq) -{ -} - static inline void trace_i915_request_in(struct i915_request *rq, unsigned int port) {