From patchwork Wed Jun 27 15:13:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jani Nikula X-Patchwork-Id: 10491931 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A955F60375 for ; Wed, 27 Jun 2018 15:13:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E29302947C for ; Wed, 27 Jun 2018 15:13:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5F532947E; Wed, 27 Jun 2018 15:13:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6E8CA2947C for ; Wed, 27 Jun 2018 15:13:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EFE36E6BE; Wed, 27 Jun 2018 15:13:18 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEDE56E6BE; Wed, 27 Jun 2018 15:13:16 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:13:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="67767007" Received: from jnikula-mobl2.fi.intel.com (HELO localhost) ([10.237.72.62]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2018 08:13:15 -0700 From: Jani Nikula To: dim-tools@lists.freedesktop.org Date: Wed, 27 Jun 2018 18:13:00 +0300 Message-Id: <20180627151301.9674-1-jani.nikula@intel.com> X-Mailer: git-send-email 2.11.0 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: [Intel-gfx] [DIM DOCS PATCH 1/2] doc: update CI and pre-merge details in committer guidelines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Lots has happened in the CI front since the first version was added. Signed-off-by: Jani Nikula Acked-by: Rodrigo Vivi --- drm-intel.rst | 45 ++++++++++++++++++++++++++++----------------- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drm-intel.rst b/drm-intel.rst index c68949a41c95..baf48f459dd9 100644 --- a/drm-intel.rst +++ b/drm-intel.rst @@ -172,6 +172,8 @@ An inexhaustive list of details to check: `details on testing requirements `_. +* The patch series has passed CI pre-merge testing. See CI details below. + * An open source userspace, reviewed and ready for merging by the upstream project, must be available for new kernel ABI. Please see `details on upstreaming requirements @@ -186,11 +188,6 @@ An inexhaustive list of details to check: (or the author) stand a chance to fairly quickly understand what goes wrong if the commit is reported to cause a regression? -* `checkpatch.pl` does not complain. (Some of the more subjective warnings may - be ignored at the committer's discretion.) - -* The patch does not introduce new `sparse` warnings. - * When pushing someone else's patch you must add your own signed-off per http://developercertificate.org/. dim apply-branch should do this automatically for you. @@ -244,8 +241,6 @@ On Confidence, Complexity, and Transparency you have involved enough people to feel comfortable if the justification for the commit is questioned afterwards. -* Make sure pre-merge testing is completed successfully. - On Rough Consensus ------------------ @@ -290,18 +285,34 @@ discussions happen in public forums, and make sure there's a searchable permanent record of any discussions for later reference. This means that for most things internal meetings are not the most suitable venue. -Pre-Merge Testing ------------------ +Continuous Integration and Pre-Merge Testing +-------------------------------------------- + +The requirements for CI_ pre-merge testing are: + +* ``checkpatch.pl`` does not complain. (Some of the more subjective warnings may + be ignored at the committer's discretion.) + +* The patch does not introduce new ``sparse`` warnings. + +* Patch series must pass IGT Basic Acceptance Tests (BAT) on all the CI machines + without causing regressions. + +* Patch series must pass full IGT tests on CI shard machines without causing + regressions. + +The CI bots will send results to the patch author and intel-gfx for any patches +tracked by patchwork. The results are also available on patchwork_ and the CI_ +site. + +Check CI failures and make sure any sporadic failures are a) pre-existing, +and b) tracked in bugzilla. If there's anything dubious that you can't track +down to pre-existing and tracked issues please don't push, but instead figure +out what's going on. -Our CI infrastructure is being built up and currently requirements for pre-merge -testing are fairly simple: +.. _CI: https://intel-gfx-ci.01.org/ -* All patches must past IGT Basic Acceptance Tests (BAT) on all the CI machines - without causing regressions. The CI bots will send results to intel-gfx for - any patches tracked by patchwork. Check CI failures and make sure any sporadic - failures are a) pre-existing b) tracked in bugzilla. If there's anything - dubious that you can't track down to pre-existing&tracked issues please don't - push, but instead figure out what's going on. +.. _patchwork: https://patchwork.freedesktop.org/project/intel-gfx/series/ Tooling =======