From patchwork Tue Jul 3 15:41:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 10504533 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DBC0D602BC for ; Tue, 3 Jul 2018 15:41:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA3292522B for ; Tue, 3 Jul 2018 15:41:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BC1EC24603; Tue, 3 Jul 2018 15:41:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 41D8E24603 for ; Tue, 3 Jul 2018 15:41:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 614266E7E1; Tue, 3 Jul 2018 15:41:48 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE41A6E05B; Tue, 3 Jul 2018 15:41:46 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 12239924-1500050 for multiple; Tue, 03 Jul 2018 16:41:37 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Tue, 3 Jul 2018 16:41:35 +0100 Message-Id: <20180703154135.14101-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] lib/rendercopy: Use gen8_wm_kernel__affine X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The shaders/blit.g7a has weird artefacts (random pixel kill) when drawing with to an odd destination coordinate. Rather than debug the issue with the assembler, replace the kernel with the one used by SNA for simple copies. Reported-by: Ville Syrjälä Signed-off-by: Chris Wilson Tested-by: Ville Syrjälä Acked-by: Ville Syrjälä --- lib/rendercopy_gen8.c | 10 ++++------ lib/rendercopy_gen9.c | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c index 2b5d9b52e..2e590e391 100644 --- a/lib/rendercopy_gen8.c +++ b/lib/rendercopy_gen8.c @@ -51,12 +51,10 @@ struct { /* see shaders/ps/blit.g7a */ static const uint32_t ps_kernel[][4] = { #if 1 - { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 }, - { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 }, - { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 }, - { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 }, - { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 }, - { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 }, + { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 }, + { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 }, + { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 }, + { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 }, #else /* Write all -1 */ { 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 }, diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c index 0157ced9c..79e312409 100644 --- a/lib/rendercopy_gen9.c +++ b/lib/rendercopy_gen9.c @@ -52,12 +52,10 @@ struct { /* see shaders/ps/blit.g7a */ static const uint32_t ps_kernel[][4] = { #if 1 - { 0x0060005a, 0x21403ae8, 0x3a0000c0, 0x008d0040 }, - { 0x0060005a, 0x21603ae8, 0x3a0000c0, 0x008d0080 }, - { 0x0060005a, 0x21803ae8, 0x3a0000d0, 0x008d0040 }, - { 0x0060005a, 0x21a03ae8, 0x3a0000d0, 0x008d0080 }, - { 0x02800031, 0x2e0022e8, 0x0e000140, 0x08840001 }, - { 0x05800031, 0x200022e0, 0x0e000e00, 0x90031000 }, + { 0x0080005a, 0x2f403ae8, 0x3a0000c0, 0x008d0040 }, + { 0x0080005a, 0x2f803ae8, 0x3a0000d0, 0x008d0040 }, + { 0x02800031, 0x2e203a48, 0x0e8d0f40, 0x08840001 }, + { 0x05800031, 0x20003a40, 0x0e8d0e20, 0x90031000 }, #else /* Write all -1 */ { 0x00600001, 0x2e000608, 0x00000000, 0x3f800000 },