diff mbox

drm/i915/psr: Remove useless function calls.

Message ID 20180711220050.21809-1-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi July 11, 2018, 10 p.m. UTC
PSR is no longer supported on VLV/CHV so this is just dead code.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Souza, Jose July 11, 2018, 10:04 p.m. UTC | #1
On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote:
> PSR is no longer supported on VLV/CHV so this is just dead code.

> 


Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---

>  drivers/gpu/drm/i915/intel_dp.c | 7 -------

>  1 file changed, 7 deletions(-)

> 

> diff --git a/drivers/gpu/drm/i915/intel_dp.c

> b/drivers/gpu/drm/i915/intel_dp.c

> index 5be07e1d816d..7d40bfcb1bbb 100644

> --- a/drivers/gpu/drm/i915/intel_dp.c

> +++ b/drivers/gpu/drm/i915/intel_dp.c

> @@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct

> intel_encoder *encoder,

>  			   const struct intel_crtc_state

> *old_crtc_state,

>  			   const struct drm_connector_state

> *old_conn_state)

>  {

> -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);

> -

> -	intel_psr_disable(intel_dp, old_crtc_state);

> -

>  	intel_disable_dp(encoder, old_crtc_state, old_conn_state);

>  }

>  

> @@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder

> *encoder,

>  			  const struct intel_crtc_state

> *pipe_config,

>  			  const struct drm_connector_state

> *conn_state)

>  {

> -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);

> -

>  	intel_edp_backlight_on(pipe_config, conn_state);

> -	intel_psr_enable(intel_dp, pipe_config);

>  }

>  

>  static void g4x_pre_enable_dp(struct intel_encoder *encoder,
Rodrigo Vivi July 13, 2018, 6:40 a.m. UTC | #2
On Wed, Jul 11, 2018 at 10:04:00PM +0000, Souza, Jose wrote:
> On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote:
> > PSR is no longer supported on VLV/CHV so this is just dead code.
> > 
> 
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

pushed to dinq, thanks

> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c
> > b/drivers/gpu/drm/i915/intel_dp.c
> > index 5be07e1d816d..7d40bfcb1bbb 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
> > intel_encoder *encoder,
> >  			   const struct intel_crtc_state
> > *old_crtc_state,
> >  			   const struct drm_connector_state
> > *old_conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> > -	intel_psr_disable(intel_dp, old_crtc_state);
> > -
> >  	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
> >  }
> >  
> > @@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
> > *encoder,
> >  			  const struct intel_crtc_state
> > *pipe_config,
> >  			  const struct drm_connector_state
> > *conn_state)
> >  {
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
> > -
> >  	intel_edp_backlight_on(pipe_config, conn_state);
> > -	intel_psr_enable(intel_dp, pipe_config);
> >  }
> >  
> >  static void g4x_pre_enable_dp(struct intel_encoder *encoder,
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 5be07e1d816d..7d40bfcb1bbb 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2830,10 +2830,6 @@  static void vlv_disable_dp(struct intel_encoder *encoder,
 			   const struct intel_crtc_state *old_crtc_state,
 			   const struct drm_connector_state *old_conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
-	intel_psr_disable(intel_dp, old_crtc_state);
-
 	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
 }
 
@@ -3046,10 +3042,7 @@  static void vlv_enable_dp(struct intel_encoder *encoder,
 			  const struct intel_crtc_state *pipe_config,
 			  const struct drm_connector_state *conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
 	intel_edp_backlight_on(pipe_config, conn_state);
-	intel_psr_enable(intel_dp, pipe_config);
 }
 
 static void g4x_pre_enable_dp(struct intel_encoder *encoder,