| Message ID | 20180713175741.14547-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting Chris Wilson (2018-07-13 18:57:41) > This was always a placeholder for GVT stakeholders to provide some > better tests. 2 years later and none have been put forward so stop > wasting CI's time running a placeholder. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106989 > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Zhi Wang <zhi.a.wang@intel.com> Martin, would you care to ack? -Chris > --- > tests/Makefile.sources | 1 - > tests/gvt_basic.c | 44 --------------------------- > tests/intel-ci/fast-feedback.testlist | 1 - > tests/meson.build | 1 - > 4 files changed, 47 deletions(-) > delete mode 100644 tests/gvt_basic.c
On 17/07/18 15:43, Chris Wilson wrote: > Quoting Chris Wilson (2018-07-13 18:57:41) >> This was always a placeholder for GVT stakeholders to provide some >> better tests. 2 years later and none have been put forward so stop >> wasting CI's time running a placeholder. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106989 >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >> Cc: Zhi Wang <zhi.a.wang@intel.com> > > Martin, would you care to ack? ACK, since we have no tests for GVT-d anyway, we can consider it is broken by default: Acked-by: Martin Peres <martin.peres@linux.intel.com> Zhi, please write IGT tests for GVT-d and we'll run the tests and file bugs when regressing them! Cheers, Martin
On 17/07/18 05:43, Chris Wilson wrote: > Quoting Chris Wilson (2018-07-13 18:57:41) >> This was always a placeholder for GVT stakeholders to provide some >> better tests. 2 years later and none have been put forward so stop >> wasting CI's time running a placeholder. >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106989 >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >> Cc: Zhi Wang <zhi.a.wang@intel.com> > > Martin, would you care to ack? Do we cover loading the module with enable_gvt=1 somewhere? Thanks, Antonio > -Chris > >> --- >> tests/Makefile.sources | 1 - >> tests/gvt_basic.c | 44 --------------------------- >> tests/intel-ci/fast-feedback.testlist | 1 - >> tests/meson.build | 1 - >> 4 files changed, 47 deletions(-) >> delete mode 100644 tests/gvt_basic.c > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev >
diff --git a/tests/Makefile.sources b/tests/Makefile.sources index 6ca7b810b..550765bbe 100644 --- a/tests/Makefile.sources +++ b/tests/Makefile.sources @@ -170,7 +170,6 @@ TESTS_progs = \ gen3_render_mixed_blits \ gen3_render_tiledx_blits \ gen3_render_tiledy_blits \ - gvt_basic \ i915_query \ kernel_taint \ kms_3d \ diff --git a/tests/gvt_basic.c b/tests/gvt_basic.c deleted file mode 100644 index 4e909a59f..000000000 --- a/tests/gvt_basic.c +++ /dev/null @@ -1,44 +0,0 @@ -/* - * Copyright © 2016 Intel Corporation - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice (including the next - * paragraph) shall be included in all copies or substantial portions of the - * Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS - * IN THE SOFTWARE. - */ - -#include "igt.h" -#include "igt_gvt.h" - -IGT_TEST_DESCRIPTION("Basic sanity check of i915 Guest Virtualisation"); - -igt_main -{ - int fd = -1; - - igt_fixture { - igt_require(igt_gvt_load_module()); - fd = __drm_open_driver(DRIVER_INTEL); - } - - igt_subtest_f("invalid-placeholder-test"); - - igt_fixture { - close(fd); - igt_gvt_unload_module(); - } -} diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 207f42ed4..882c5e8cf 100644 --- a/tests/intel-ci/fast-feedback.testlist +++ b/tests/intel-ci/fast-feedback.testlist @@ -293,4 +293,3 @@ igt@drv_module_reload@basic-reload igt@drv_module_reload@basic-mmio-debug igt@drv_module_reload@basic-no-display igt@drv_module_reload@basic-reload-inject -igt@gvt_basic@invalid-placeholder-test diff --git a/tests/meson.build b/tests/meson.build index f980d0365..dd9d96d22 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -146,7 +146,6 @@ test_progs = [ 'gen3_render_mixed_blits', 'gen3_render_tiledx_blits', 'gen3_render_tiledy_blits', - 'gvt_basic', 'i915_query', 'kms_3d', 'kms_addfb_basic',
This was always a placeholder for GVT stakeholders to provide some better tests. 2 years later and none have been put forward so stop wasting CI's time running a placeholder. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106989 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Zhi Wang <zhi.a.wang@intel.com> --- tests/Makefile.sources | 1 - tests/gvt_basic.c | 44 --------------------------- tests/intel-ci/fast-feedback.testlist | 1 - tests/meson.build | 1 - 4 files changed, 47 deletions(-) delete mode 100644 tests/gvt_basic.c