diff mbox

[i-g-t,7/8] trace.pl: Basic preemption support

Message ID 20180718094514.5903-8-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin July 18, 2018, 9:45 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Just forget about earlier request_in events.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 scripts/trace.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

John Harrison July 18, 2018, 8:13 p.m. UTC | #1
On 7/18/2018 2:45 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Just forget about earlier request_in events.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   scripts/trace.pl | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 60d42865acbd..41bedeefb776 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -408,7 +408,9 @@ while (<>) {
>   	} elsif ($tp_name eq 'i915:i915_request_in:') {
>   		my %req;
>   
> -		die if exists $db{$key};
> +		# preemption
> +		delete $db{$key} if exists $db{$key};
> +
>   		die unless exists $queue{$key};
>   		die unless exists $submit{$key};
>   

I've definitely r-b'd this one before too. And no changes so still...

Reviewed-by: John Harrison<John.C.Harrison@Intel.com>
diff mbox

Patch

diff --git a/scripts/trace.pl b/scripts/trace.pl
index 60d42865acbd..41bedeefb776 100755
--- a/scripts/trace.pl
+++ b/scripts/trace.pl
@@ -408,7 +408,9 @@  while (<>) {
 	} elsif ($tp_name eq 'i915:i915_request_in:') {
 		my %req;
 
-		die if exists $db{$key};
+		# preemption
+		delete $db{$key} if exists $db{$key};
+
 		die unless exists $queue{$key};
 		die unless exists $submit{$key};