| Message ID | 20180719093601.11788-4-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Bring back the button which expands/stacks overlapping timeline boxes. > > We default to no stacking, but sometimes expanding the view can be useful, > especially with deep request pipelines. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > --- > scripts/trace.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/trace.pl b/scripts/trace.pl > index 59f6d32dc3c8..1924333e12b6 100755 > --- a/scripts/trace.pl > +++ b/scripts/trace.pl > @@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'. > <p> > Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline. > </p> > +<button onclick="toggleStacking()">Toggle overlap stacking</button> > </td> > </tr> > </table> > @@ -1284,6 +1285,12 @@ print <<ENDHTML; > > // Create a Timeline > var timeline = new vis.Timeline(container, items, groups, options); > + > + function toggleStacking() { > + options.stack = !options.stack; > + options.stackSubgroups = !options.stackSubgroups; > + timeline.setOptions(options); > + } > ENDHTML > > print <<ENDHTML; Reviewed-by: John Harrison <John.C.Harrison@Intel.com> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote:<br> <blockquote type="cite" cite="mid:20180719093601.11788-4-tvrtko.ursulin@linux.intel.com"> <pre wrap="">From: Tvrtko Ursulin <a class="moz-txt-link-rfc2396E" href="mailto:tvrtko.ursulin@intel.com"><tvrtko.ursulin@intel.com></a> Bring back the button which expands/stacks overlapping timeline boxes. We default to no stacking, but sometimes expanding the view can be useful, especially with deep request pipelines. Signed-off-by: Tvrtko Ursulin <a class="moz-txt-link-rfc2396E" href="mailto:tvrtko.ursulin@intel.com"><tvrtko.ursulin@intel.com></a> --- scripts/trace.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/trace.pl b/scripts/trace.pl index 59f6d32dc3c8..1924333e12b6 100755 --- a/scripts/trace.pl +++ b/scripts/trace.pl @@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'. <p> Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline. </p> +<button onclick="toggleStacking()">Toggle overlap stacking</button> </td> </tr> </table> @@ -1284,6 +1285,12 @@ print <<ENDHTML; // Create a Timeline var timeline = new vis.Timeline(container, items, groups, options); + + function toggleStacking() { + options.stack = !options.stack; + options.stackSubgroups = !options.stackSubgroups; + timeline.setOptions(options); + } ENDHTML print <<ENDHTML; </pre> </blockquote> <br> Reviewed-by: John Harrison <a class="moz-txt-link-rfc2396E" href="mailto:John.C.Harrison@Intel.com"><John.C.Harrison@Intel.com></a><br> <br> </body> </html>
On 27/07/2018 22:47, John Harrison wrote: > On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin<tvrtko.ursulin@intel.com> >> >> Bring back the button which expands/stacks overlapping timeline boxes. >> >> We default to no stacking, but sometimes expanding the view can be useful, >> especially with deep request pipelines. >> >> Signed-off-by: Tvrtko Ursulin<tvrtko.ursulin@intel.com> >> --- >> scripts/trace.pl | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/scripts/trace.pl b/scripts/trace.pl >> index 59f6d32dc3c8..1924333e12b6 100755 >> --- a/scripts/trace.pl >> +++ b/scripts/trace.pl >> @@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'. >> <p> >> Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline. >> </p> >> +<button onclick="toggleStacking()">Toggle overlap stacking</button> >> </td> >> </tr> >> </table> >> @@ -1284,6 +1285,12 @@ print <<ENDHTML; >> >> // Create a Timeline >> var timeline = new vis.Timeline(container, items, groups, options); >> + >> + function toggleStacking() { >> + options.stack = !options.stack; >> + options.stackSubgroups = !options.stackSubgroups; >> + timeline.setOptions(options); >> + } >> ENDHTML >> >> print <<ENDHTML; > > Reviewed-by: John Harrison <John.C.Harrison@Intel.com> Pushed up to this one, thanks! (BTW this reply even patchwork did not see. But it saw your replies to 1 & 2.) Regards, Tvrtko
diff --git a/scripts/trace.pl b/scripts/trace.pl index 59f6d32dc3c8..1924333e12b6 100755 --- a/scripts/trace.pl +++ b/scripts/trace.pl @@ -935,6 +935,7 @@ Boxes are in format 'ctx-id/seqno'. <p> Use Ctrl+scroll-action to zoom-in/out and scroll-action or dragging to move around the timeline. </p> +<button onclick="toggleStacking()">Toggle overlap stacking</button> </td> </tr> </table> @@ -1284,6 +1285,12 @@ print <<ENDHTML; // Create a Timeline var timeline = new vis.Timeline(container, items, groups, options); + + function toggleStacking() { + options.stack = !options.stack; + options.stackSubgroups = !options.stackSubgroups; + timeline.setOptions(options); + } ENDHTML print <<ENDHTML;