| Message ID | 20180809124544.9250-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vgem: Remove unecessary dma_fence_ops | expand |
Quoting Daniel Vetter (2018-08-09 13:45:44) > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > Also remove the ->signaled callback, vgem can't peek ahead with a > fastpath, returning false is the default implementation. > > v2: Protect the meaningful space! (Chris) > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Kees Cook <keescook@chromium.org> > Cc: Cihangir Akturk <cakturk@gmail.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> 1-4, Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
On Thu, Aug 09, 2018 at 01:48:42PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-08-09 13:45:44) > > dma_fence_default_wait is the default now, same for the trivial > > enable_signaling implementation. > > > > Also remove the ->signaled callback, vgem can't peek ahead with a > > fastpath, returning false is the default implementation. > > > > v2: Protect the meaningful space! (Chris) > > > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Kees Cook <keescook@chromium.org> > > Cc: Cihangir Akturk <cakturk@gmail.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Sean Paul <seanpaul@chromium.org> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > 1-4, > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Thanks for your reviews, all four pushed to drm-misc-next now. -Daniel
diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c index b28876c222b4..e6ee71323a66 100644 --- a/drivers/gpu/drm/vgem/vgem_fence.c +++ b/drivers/gpu/drm/vgem/vgem_fence.c @@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct dma_fence *fence) return "unbound"; } -static bool vgem_fence_signaled(struct dma_fence *fence) -{ - return false; -} - -static bool vgem_fence_enable_signaling(struct dma_fence *fence) -{ - return true; -} - static void vgem_fence_release(struct dma_fence *base) { struct vgem_fence *fence = container_of(base, typeof(*fence), base); @@ -76,9 +66,6 @@ static void vgem_fence_timeline_value_str(struct dma_fence *fence, char *str, static const struct dma_fence_ops vgem_fence_ops = { .get_driver_name = vgem_fence_get_driver_name, .get_timeline_name = vgem_fence_get_timeline_name, - .enable_signaling = vgem_fence_enable_signaling, - .signaled = vgem_fence_signaled, - .wait = dma_fence_default_wait, .release = vgem_fence_release, .fence_value_str = vgem_fence_value_str,
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Also remove the ->signaled callback, vgem can't peek ahead with a fastpath, returning false is the default implementation. v2: Protect the meaningful space! (Chris) Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Kees Cook <keescook@chromium.org> Cc: Cihangir Akturk <cakturk@gmail.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Sean Paul <seanpaul@chromium.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/vgem/vgem_fence.c | 13 ------------- 1 file changed, 13 deletions(-)