From patchwork Mon Sep 3 16:54:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10586179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F102B139B for ; Mon, 3 Sep 2018 16:55:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E020828CDB for ; Mon, 3 Sep 2018 16:55:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D4B6328F5D; Mon, 3 Sep 2018 16:55:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7064628FE6 for ; Mon, 3 Sep 2018 16:55:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CB536E2B9; Mon, 3 Sep 2018 16:55:06 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id F36C46E2B2 for ; Mon, 3 Sep 2018 16:55:03 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id a20-v6so1243586edd.4 for ; Mon, 03 Sep 2018 09:55:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xgpg9SrQEI7QSilImCQ+wvXmEmCTvZVuS+hzjic8sOA=; b=f2qr+WD/RjT+C6qZXs8t8zOLDpBckCYKUdA2REdmt6NhI8Jqy+xUfthyWZtq2vlRAi twrbv+Pc1+MHElQmr5j+v8PSTilNN6RbEv6YIbP8Nio5K5qsjz1ksxkg3vU3gDfRshko qJ/qNnsx5kUIvX8I7mxgvVNQTa3FedC9mgNiyxyMYOQjmPkaDoVHCnc226TUcPXPAZ7K t2EMELWYSu2XF9K+RdJ58e16M+0fnysZV3xT2Uh/si91Tq3XhWFU4pQcG9cKn9B7faBK 7ByZpzoA5qMYfSSe9S4pdP4YQoqfvwMZ22juIMrz2D5iPrz5bShDyDBeflqEU+EQQsCh mLTg== X-Gm-Message-State: APzg51BoXrLL+HAF61HkTBWhY/vn9SZrn9IkFyjwH4eI3pEJol1sZF+4 xof79d3Iv+hgdtd1gGKyvrntKA== X-Google-Smtp-Source: ANB0VdbPl0o7vsswZLUQCRkD8wNxnWXWpOzYXkfgfERLZI6nxpgnpDCKr2b/Mkpvdvdq9QNNCx1JdA== X-Received: by 2002:a50:94c4:: with SMTP id t4-v6mr32030277eda.306.1535993702692; Mon, 03 Sep 2018 09:55:02 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id u53-v6sm12777790edm.51.2018.09.03.09.55.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Sep 2018 09:55:02 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Mon, 3 Sep 2018 18:54:36 +0200 Message-Id: <20180903165439.24845-11-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180903165439.24845-1-daniel.vetter@ffwll.ch> References: <20180903165439.24845-1-daniel.vetter@ffwll.ch> Subject: [Intel-gfx] [PATCH 11/14] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , VMware Graphics , Thomas Hellstrom , Sinclair Yeh MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The core _does_ the call to drm_atomic_commit for you. That's pretty much the entire point of having the fancy new atomic_set/get_prop callbacks. Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 0c25bb8faf80..0f7e116a59f0 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -2309,12 +2309,6 @@ vmw_du_connector_atomic_set_property(struct drm_connector *connector, if (property == dev_priv->implicit_placement_property) { vcs->is_implicit = val; - - /* - * We should really be doing a drm_atomic_commit() to - * commit the new state, but since this doesn't cause - * an immedate state change, this is probably ok - */ du->is_implicit = vcs->is_implicit; } else { return -EINVAL;