From patchwork Tue Sep 18 11:21:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 10604195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AFAB5A4 for ; Tue, 18 Sep 2018 11:21:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A2BF2A546 for ; Tue, 18 Sep 2018 11:21:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E2932A5B1; Tue, 18 Sep 2018 11:21:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E5A5E2A546 for ; Tue, 18 Sep 2018 11:21:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68A9A6E3C1; Tue, 18 Sep 2018 11:21:19 +0000 (UTC) X-Original-To: Intel-gfx@lists.freedesktop.org Delivered-To: Intel-gfx@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10FF46E172 for ; Tue, 18 Sep 2018 11:21:16 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id k5-v6so1650710wre.10 for ; Tue, 18 Sep 2018 04:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=65lcpQ0sDkQV7FF4TNxYAvCwg/6bG6CXpUPnYH+bbKk=; b=gsh9X/8IWVEk3P3WDBZgy0U3X9PzQm3r9aCHODaZMtrK3umnfKVuHdmiRoX2WGwHuZ q9Kcvi3wWNDh0vfd7rUvAicI4uXpOpFQPzXNA9TSYu4PklloIqa7WSmSRCKTRHksJSED 8iAX4UbanaUG4pqaIYLXKrAqtmENRDSAVXTJADPv9zJkYdWDQrWua7PTI5aTJzV0ZLKR UoBlxpev8/8pEQ+g4mXgTqUH/G/YHDfHLDcmRvNHcDQshCGFjQAzxcAANpXikVXEHmch NsvfD3UuuqXiQorw0a432JBJUdbJz4JDuX/rP22dfMUvuABmF0VkUuK8QLbRxtELqZDE uHAA== X-Gm-Message-State: APzg51AvTRHXyazjPcRtlq8ZCxtNebB30YtUHCHWHUtbttZQa8Y/5GRT 366jaJvyVeA0wT6v1dVvxkZ3aw== X-Google-Smtp-Source: ANB0VdZLus7IPTuvhBsSgNauvcsAbZdAIHOpN7ODhlL0cfFlyvq+z7kvy5IN2K95FdN18rCpBN+4BQ== X-Received: by 2002:adf:9031:: with SMTP id h46-v6mr22619002wrh.248.1537269675480; Tue, 18 Sep 2018 04:21:15 -0700 (PDT) Received: from localhost.localdomain ([95.144.165.37]) by smtp.gmail.com with ESMTPSA id x204-v6sm1894641wmg.27.2018.09.18.04.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Sep 2018 04:21:15 -0700 (PDT) From: Tvrtko Ursulin X-Google-Original-From: Tvrtko Ursulin To: igt-dev@lists.freedesktop.org Date: Tue, 18 Sep 2018 12:21:10 +0100 Message-Id: <20180918112110.3377-1-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <153726880187.19296.12497849144526886330@skylake-alporthouse-com> References: <153726880187.19296.12497849144526886330@skylake-alporthouse-com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t v4 1/2] tests/gem_ctx_bad_exec: Consolidate to gem_ctx_exec X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP From: Tvrtko Ursulin Move a really small test that invalid context is rejected under the gem_ctx_exec umbrella. v2: * And actually fix the test so it does what it claims. And add more variety in the invalid context id's it tests with. (Chris Wilson) v3: * Rename the test as basic. * Limit to 32-bit. (Chris Wilson) * Add previously valid but closed context id to the test. (Chris Wilson) v4: * Add more invalid values. (Chris Wilson) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- tests/Makefile.sources | 1 - tests/gem_ctx_bad_exec.c | 60 ---------------------------------------- tests/gem_ctx_exec.c | 46 ++++++++++++++++++++++++++++++ tests/meson.build | 1 - 4 files changed, 46 insertions(+), 62 deletions(-) delete mode 100644 tests/gem_ctx_bad_exec.c diff --git a/tests/Makefile.sources b/tests/Makefile.sources index c84933f1d971..269336ad3150 100644 --- a/tests/Makefile.sources +++ b/tests/Makefile.sources @@ -51,7 +51,6 @@ TESTS_progs = \ gem_cs_prefetch \ gem_cs_tlb \ gem_ctx_bad_destroy \ - gem_ctx_bad_exec \ gem_ctx_create \ gem_ctx_exec \ gem_ctx_isolation \ diff --git a/tests/gem_ctx_bad_exec.c b/tests/gem_ctx_bad_exec.c deleted file mode 100644 index e3ccc5be46a0..000000000000 --- a/tests/gem_ctx_bad_exec.c +++ /dev/null @@ -1,60 +0,0 @@ -/* - * Copyright © 2012 Intel Corporation - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice (including the next - * paragraph) shall be included in all copies or substantial portions of the - * Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS - * IN THE SOFTWARE. - * - */ - -#include "igt.h" - -IGT_TEST_DESCRIPTION("Test that context cannot be submitted to any ring"); - -static int exec(int fd, unsigned ring) -{ - struct drm_i915_gem_execbuffer2 execbuf; - struct drm_i915_gem_exec_object2 obj; - - memset(&obj, 0, sizeof(obj)); - memset(&execbuf, 0, sizeof(execbuf)); - - execbuf.buffers_ptr = to_user_pointer(&obj); - execbuf.buffer_count = 1; - i915_execbuffer2_set_context_id(execbuf, 1); - - return __gem_execbuf(fd, &execbuf); -} - -igt_main -{ - const struct intel_execution_engine *e; - int fd = -1; - - igt_skip_on_simulation(); - - igt_fixture - fd = drm_open_driver_render(DRIVER_INTEL); - - for (e = intel_execution_engines; e->name; e++) { - igt_subtest_f("%s", e->name) { - gem_require_ring(fd, e->exec_id | e->flags); - igt_assert_eq(exec(fd, e->exec_id | e->flags), -ENOENT); - } - } -} diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c index 1f8ed64d4bd3..f02a88b1acfc 100644 --- a/tests/gem_ctx_exec.c +++ b/tests/gem_ctx_exec.c @@ -30,6 +30,7 @@ */ #include "igt.h" +#include #include #include #include @@ -142,6 +143,42 @@ static void big_exec(int fd, uint32_t handle, int ring) gem_sync(fd, handle); } +static void invalid_context(int fd, unsigned ring, uint32_t handle) +{ + struct drm_i915_gem_exec_object2 obj = { + .handle = handle, + }; + struct drm_i915_gem_execbuffer2 execbuf = { + .buffers_ptr = to_user_pointer(&obj), + .buffer_count = 1, + .flags = ring, + }; + unsigned int i; + uint32_t ctx; + + /* Verify everything works. */ + i915_execbuffer2_set_context_id(execbuf, 0); + gem_execbuf(fd, &execbuf); + + ctx = gem_context_create(fd); + i915_execbuffer2_set_context_id(execbuf, ctx); + gem_execbuf(fd, &execbuf); + + gem_context_destroy(fd, ctx); + + /* Go through the non-existent context id's. */ + for (i = 0; i < 32; i++) { + i915_execbuffer2_set_context_id(execbuf, 1UL << i); + igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT); + } + + i915_execbuffer2_set_context_id(execbuf, INT_MAX); + igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT); + + i915_execbuffer2_set_context_id(execbuf, UINT_MAX); + igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT); +} + uint32_t handle; uint32_t batch[2] = {0, MI_BATCH_BUFFER_END}; uint32_t ctx_id, ctx_id2; @@ -149,6 +186,8 @@ int fd; igt_main { + const struct intel_execution_engine *e; + igt_fixture { fd = drm_open_driver_render(DRIVER_INTEL); igt_require_gem(fd); @@ -174,6 +213,13 @@ igt_main gem_sync(fd, handle); } + for (e = intel_execution_engines; e->name; e++) { + igt_subtest_f("basic-invalid-context-%s", e->name) { + gem_require_ring(fd, e->exec_id | e->flags); + invalid_context(fd, e->exec_id | e->flags, handle); + } + } + igt_subtest("eviction") big_exec(fd, handle, I915_EXEC_RENDER); diff --git a/tests/meson.build b/tests/meson.build index 17deb945ec95..d22d59e0837d 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -28,7 +28,6 @@ test_progs = [ 'gem_cs_prefetch', 'gem_cs_tlb', 'gem_ctx_bad_destroy', - 'gem_ctx_bad_exec', 'gem_ctx_create', 'gem_ctx_exec', 'gem_ctx_isolation',