diff mbox series

[6/6] drm/i915: promote ddb update message to DRM_DEBUG_KMS

Message ID 20181004231600.14101-7-paulo.r.zanoni@intel.com (mailing list archive)
State New, archived
Headers show
Series Watermarks small fixes/improvements | expand

Commit Message

Zanoni, Paulo R Oct. 4, 2018, 11:16 p.m. UTC
This message is currently marked as DRM_DEBUG_ATOMIC. I would like it
to be DRM_DEBUG_KMS since it is more KMS than atomic, and this will
also make the message appear in the CI logs, which may or may not help
us with some FIFO underrun bugs.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Matt Roper Oct. 10, 2018, 1:55 a.m. UTC | #1
On Thu, Oct 04, 2018 at 04:16:00PM -0700, Paulo Zanoni wrote:
> This message is currently marked as DRM_DEBUG_ATOMIC. I would like it
> to be DRM_DEBUG_KMS since it is more KMS than atomic, and this will
> also make the message appear in the CI logs, which may or may not help
> us with some FIFO underrun bugs.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 53b4a9a2de69..6cacddd16010 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5233,11 +5233,11 @@ skl_print_wm_changes(const struct drm_atomic_state *state)
>  			if (skl_ddb_entry_equal(old, new))
>  				continue;
>  
> -			DRM_DEBUG_ATOMIC("[PLANE:%d:%s] ddb (%d - %d) -> (%d - %d)\n",
> -					 intel_plane->base.base.id,
> -					 intel_plane->base.name,
> -					 old->start, old->end,
> -					 new->start, new->end);
> +			DRM_DEBUG_KMS("[PLANE:%d:%s] ddb (%d - %d) -> (%d - %d)\n",
> +				      intel_plane->base.base.id,
> +				      intel_plane->base.name,
> +				      old->start, old->end,
> +				      new->start, new->end);
>  		}
>  	}
>  }
> -- 
> 2.14.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 53b4a9a2de69..6cacddd16010 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5233,11 +5233,11 @@  skl_print_wm_changes(const struct drm_atomic_state *state)
 			if (skl_ddb_entry_equal(old, new))
 				continue;
 
-			DRM_DEBUG_ATOMIC("[PLANE:%d:%s] ddb (%d - %d) -> (%d - %d)\n",
-					 intel_plane->base.base.id,
-					 intel_plane->base.name,
-					 old->start, old->end,
-					 new->start, new->end);
+			DRM_DEBUG_KMS("[PLANE:%d:%s] ddb (%d - %d) -> (%d - %d)\n",
+				      intel_plane->base.base.id,
+				      intel_plane->base.name,
+				      old->start, old->end,
+				      new->start, new->end);
 		}
 	}
 }