From patchwork Fri Nov 2 13:25:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10665539 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79C8E15E9 for ; Fri, 2 Nov 2018 13:25:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A0D72AE08 for ; Fri, 2 Nov 2018 13:25:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E4B92B008; Fri, 2 Nov 2018 13:25:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BE19C2AE08 for ; Fri, 2 Nov 2018 13:25:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E8C06E512; Fri, 2 Nov 2018 13:25:53 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B0D46E512 for ; Fri, 2 Nov 2018 13:25:51 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id c25-v6so1824968edt.8 for ; Fri, 02 Nov 2018 06:25:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qVGuUT4vVXNJOUmWrMM9WMvq+wDCLSrmeXOEWQ1oEls=; b=osjpT4+V8jYNqsuaw1VCJzZTvMX1w7rzoUNtbyc/yxWtStzqZ0FwWKqmBnjU/+BjP7 iZNK6hTqj3LLTcHm2EFe4OS35a6e0QwHiyPk0a28SG5ARtDdQbaUl2cjUZssE3nc2naX heCVnWWEGhfFl1VTELyFk0BFSNB7lToBg2LROuhsDJkWcXufD4oLhvimmsEF0WjDhmv2 yAfX/nswal64iJ3LiBSTDFcn/OZjQugcIEubA/oVE1yVRVja/yCUzfmh2e1QTgWw/Wiy 2Mol+6R4iugO5mpNU3jEvJAzavdnTtjNjbrkZDm3RVXZEL6oC+1yfEU+NOTt2w87ohun Ev+g== X-Gm-Message-State: AGRZ1gJ2LEdnsqxf0L2W3GzHkNvumVXKuCvMCRbCJQx1INYqjRvMadL9 NN43NBahNQ4ShQ6FlzDaMtOhUw== X-Google-Smtp-Source: AJdET5eLmB4+vRE3pSx6g4Y5aZzDS+jCGXf/KZXG6nB6P+VwAmxaGx28cRXZwwyAul5gOPJCr7nHzA== X-Received: by 2002:a50:b0e5:: with SMTP id j92-v6mr8579667edd.294.1541165149714; Fri, 02 Nov 2018 06:25:49 -0700 (PDT) Received: from wespe.ffwll.local ([2a02:168:569e:0:7e01:304d:1991:69d]) by smtp.gmail.com with ESMTPSA id r31-v6sm2618550edd.59.2018.11.02.06.25.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Nov 2018 06:25:48 -0700 (PDT) From: Daniel Vetter To: DRI Development Date: Fri, 2 Nov 2018 14:25:41 +0100 Message-Id: <20181102132543.16486-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.14.4 Subject: [Intel-gfx] [PATCH 1/3] drm/lease: debug output for lease creation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP I spent a bit of time scratching heads and figuring out why the igts don't work. Probably useful to keep this work. Cc: Keith Packard Cc: Dave Airlie Signed-off-by: Daniel Vetter Acked-by: Keith Packard --- drivers/gpu/drm/drm_lease.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index 9ab88db8fad0..46408278c5b1 100644 --- a/drivers/gpu/drm/drm_lease.c +++ b/drivers/gpu/drm/drm_lease.c @@ -419,14 +419,17 @@ static int fill_object_idr(struct drm_device *dev, } if (!drm_mode_object_lease_required(objects[o]->type)) { + DRM_DEBUG_KMS("invalid object for lease\n"); ret = -EINVAL; goto out_free_objects; } } ret = validate_lease(dev, lessor_priv, object_count, objects); - if (ret) + if (ret) { + DRM_DEBUG_LEASE("lease validation failed\n"); goto out_free_objects; + } /* add their IDs to the lease request - taking into account universal planes */ @@ -509,15 +512,21 @@ int drm_mode_create_lease_ioctl(struct drm_device *dev, return -EOPNOTSUPP; /* Do not allow sub-leases */ - if (lessor->lessor) + if (lessor->lessor) { + DRM_DEBUG_LEASE("recursive leasing not allowed\n"); return -EINVAL; + } /* need some objects */ - if (cl->object_count == 0) + if (cl->object_count == 0) { + DRM_DEBUG_LEASE("no objects in lease\n"); return -EINVAL; + } - if (cl->flags && (cl->flags & ~(O_CLOEXEC | O_NONBLOCK))) + if (cl->flags && (cl->flags & ~(O_CLOEXEC | O_NONBLOCK))) { + DRM_DEBUG_LEASE("invalid flags\n"); return -EINVAL; + } object_count = cl->object_count; @@ -532,6 +541,7 @@ int drm_mode_create_lease_ioctl(struct drm_device *dev, object_count, object_ids); kfree(object_ids); if (ret) { + DRM_DEBUG_LEASE("lease object lookup failed: %i\n", ret); idr_destroy(&leases); return ret; }