| Message ID | 20181102203924.10870-1-jose.souza@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] drm/i915: Reuse the aux_domain cached | expand |
On Fri, Nov 02, 2018 at 01:39:21PM -0700, José Roberto de Souza wrote: > intel_dp_detect() caches the aux_domain in the beginning of the > function as it is used twice, so lets also use it as the aux_domain > don't change in runtime. > > Cc: Imre Deak <imre.deak@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index e7233dfa1794..52a54ef746af 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -5289,8 +5289,7 @@ intel_dp_detect(struct drm_connector *connector, > > ret = intel_dp_retrain_link(encoder, ctx); > if (ret) { > - intel_display_power_put(dev_priv, > - intel_aux_power_domain(dig_port)); > + intel_display_power_put(dev_priv, aux_domain); Thanks for catching it. status = ret; goto out_put_power; and adding the label at the end would be cleaner. Either way: Reviewed-by: Imre Deak <imre.deak@intel.com> > return ret; > } > } > -- > 2.19.1 >
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index e7233dfa1794..52a54ef746af 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -5289,8 +5289,7 @@ intel_dp_detect(struct drm_connector *connector, ret = intel_dp_retrain_link(encoder, ctx); if (ret) { - intel_display_power_put(dev_priv, - intel_aux_power_domain(dig_port)); + intel_display_power_put(dev_priv, aux_domain); return ret; } }
intel_dp_detect() caches the aux_domain in the beginning of the function as it is used twice, so lets also use it as the aux_domain don't change in runtime. Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)